Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Moment.js dependency in kbn-datemath #176450

Closed
Tracked by #170754
lukasolson opened this issue Feb 7, 2024 · 4 comments
Closed
Tracked by #170754

Remove Moment.js dependency in kbn-datemath #176450

lukasolson opened this issue Feb 7, 2024 · 4 comments
Assignees
Labels
blocked chore Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@lukasolson
Copy link
Member

Right now, the kbn-datemath package has only one dependency - Moment.js. As Moment.js is no longer actively developed, so we would like to consider how feasible it would be to remove it as a dependency. Starting with the kbn-datemath package might be a good starting point since it is a fairly small package.

@lukasolson lukasolson added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Feb 7, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal
Copy link
Member

kertal commented Feb 8, 2024

I think one of the problem here, that it's not enough to remove or replace the dependency, as consumers are passing in its moment instances, for having the right locales.

/*
* This is a simplified version of elasticsearch's date parser.
* If you pass in a momentjs instance as the third parameter the calculation
* will be done using this (and its locale settings) instead of the one bundled
* with this library.
*/

@kertal kertal added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. blocked chore labels Feb 23, 2024
@kertal
Copy link
Member

kertal commented Feb 23, 2024

Sending this to the icebox for now, it's also blocked, because to remove the Moment.js dependency, we need to make sure consumers need to no longer provide Moment instances. So this could be done in a high likely big effort to remove the Moment.js dependency from Kibana

@timductive
Copy link
Member

Closing this because it's not planned to be resolved in the foreseeable future. It will be tracked in our Icebox and will be re-opened if our priorities change. Feel free to re-open if you think it should be melted sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked chore Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

4 participants