Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for email links in a URL template for fields in Discover #179773

Closed
JessicaGarson opened this issue Apr 1, 2024 · 4 comments
Closed
Assignees
Labels
enhancement New value added to drive a business result Feature:FieldFormatters good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. papercut Small "burr" in the product that we should fix. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@JessicaGarson
Copy link

A community Slack user is looking to format a field in the URL template to direct to an email link like mailto:youremail.com.

They tried adding mailto:{{value}} to the URL template, but it redirects to a link like https://my-deployment-kb.us-east-2.aws.found.io:93/app/mailto:e25%40yahoo.com. I think this is because we only support links that start with https:// .

@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 1, 2024
@JessicaGarson JessicaGarson added Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Feature:FieldFormatters and removed Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages needs-team Issues missing a team label labels Apr 1, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 1, 2024
@dej611 dej611 added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Apr 2, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 2, 2024
@jughosta jughosta added the enhancement New value added to drive a business result label Apr 2, 2024
@kertal
Copy link
Member

kertal commented Apr 2, 2024

Has been asked before: #16983 (comment)

@kertal
Copy link
Member

kertal commented Apr 2, 2024

Currently whitelisted URL Schemas can be found here:

const whitelistUrlSchemes = ['http://', 'https://'];

On the surface it seems to be a low hanging fruit to add mailto:

@kertal kertal added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Apr 2, 2024
@kertal kertal added the good first issue low hanging fruit label Sep 2, 2024
@ghudgins ghudgins self-assigned this Nov 13, 2024
@davismcphee davismcphee added the papercut Small "burr" in the product that we should fix. label Nov 14, 2024
@ghudgins
Copy link
Contributor

addressed in #200070

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:FieldFormatters good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. papercut Small "burr" in the product that we should fix. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

7 participants