Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Apply same defaults values in extractDiffableCommonFields as in convertCreateAPIToInternalSchema #180165

Open
Tracked by #179907
jpdjere opened this issue Apr 5, 2024 · 3 comments
Open
Tracked by #179907

[Security Solution] Apply same defaults values in extractDiffableCommonFields as in convertCreateAPIToInternalSchema #180165

jpdjere opened this issue Apr 5, 2024 · 3 comments
Assignees
@jpdjere
Labels
Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area refactoring Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@jpdjere
Copy link
Contributor

jpdjere commented Apr 5, 2024 •
edited by banderror
Loading

Epics: https://github.com/elastic/security-team/issues/1974 (internal), #179907

Summary

  • The default values for the fields defined in the functions extractDiffableCommonFields and convertCreateAPIToInternalSchema are different for some fields. (See note as an example).

  • This has caused some fields to be returned as having diffs in the /upgrade/_review endpoint when they shouldn't have had. As a workaround for this, we implemented normalization in the frontend code that displays the diffs. But this shouldn't be necessary and the data should be consistent server-side.

  • In extractDiffableCommonFields, apply the same default values to the rule as in convertCreateAPIToInternalSchema, which means reuse the existing code.

  • Create reusable code that ensures that the defaults provided by extractDiffableCommonFields and convertCreateAPIToInternalSchema do not diverge over time. (comment).
@jpdjere jpdjere added triage_needed Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area labels Apr 5, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

This was referenced Apr 5, 2024
Open
Closed
@banderror banderror changed the title [Security Solution] Apply same defaults values in extractDiffableCommonFields as in convertCreateAPIToInternalSchema [Security Solution] Apply same defaults values in extractDiffableCommonFields as in convertCreateAPIToInternalSchema (DRAFT) Apr 17, 2024
@jpdjere jpdjere changed the title [Security Solution] Apply same defaults values in extractDiffableCommonFields as in convertCreateAPIToInternalSchema (DRAFT) [Security Solution] Apply same defaults values in extractDiffableCommonFields as in convertCreateAPIToInternalSchema May 24, 2024
@jpdjere jpdjere assigned jpdjere and unassigned xcrzx Jul 2, 2024
@banderror banderror mentioned this issue Nov 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpdjere jpdjere

Labels
Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area refactoring Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@xcrzx @jpdjere @banderror @elasticmachine