Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Console Monaco Migration] Improve text highlighting colors #182142

Open
ElenaStoeva opened this issue Apr 30, 2024 · 4 comments
Open

[Console Monaco Migration] Improve text highlighting colors #182142

ElenaStoeva opened this issue Apr 30, 2024 · 4 comments
Labels
enhancement New value added to drive a business result Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@ElenaStoeva
Copy link
Contributor

In #180321, we changed the text highlighting colors to match the ones from the CodeEditor theme. We should investigate whether it is possible to define unique tokens so that we can specify Console-specific highlighting colors. Ideally, we would use the colors used for the EUI code block component highlighting to maintain consistency as suggested in #180321 (review).
@ElenaStoeva ElenaStoeva added Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Apr 30, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

This was referenced Apr 30, 2024
Merged
Closed
@yuliacech
Copy link
Contributor

Related to #52985

@alisonelizabeth alisonelizabeth removed the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Sep 17, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 17, 2024
@alisonelizabeth alisonelizabeth added Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more enhancement New value added to drive a business result and removed Feature:Console Dev Tools Console Feature needs-team Issues missing a team label labels Sep 17, 2024
@alisonelizabeth
Copy link
Contributor

@ElenaStoeva is this issue still valid?

@ElenaStoeva
Copy link
Contributor Author

@ElenaStoeva is this issue still valid?

This was just a proposed improvement for the highlighting colors to match the ones from EUI Code Block, but I'd say it's a low priority for now as the current highlighting colors are working well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New value added to drive a business result Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alisonelizabeth @yuliacech @elasticmachine @ElenaStoeva