Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard][Collapsable Panels] Lower bundle size #190380

Open
Tracked by #190342
ThomThomson opened this issue Aug 12, 2024 · 0 comments
Open
Tracked by #190342

[Dashboard][Collapsable Panels] Lower bundle size #190380

ThomThomson opened this issue Aug 12, 2024 · 0 comments
Labels
Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:Collapsable Panels Related to the project for adding collapsable sections to Dashboards. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

ThomThomson commented Aug 12, 2024

kbn grid layout should be smaller than react grid layout in terms of bundle sizing. If it is larger, or if we'd like to lower the size even further we can optionally consider the following:

  1. Make the kbn grid layout package take a new isEditable prop.
  2. Make a simple fallback component that renders each panel as simply as possible via CSS grid with no drag events or any other code.
  3. When the grid is rendered with isEditable false, it should render the simple fallback.
  4. When the isEditable prop changes to true, the @kbn/grid-layout package can async import the editable version of the grid, continuing to show the non-editable component while the editable one loads.

In this way we can reduce the bundle size of our layout engine to near nothing (a simple CSS grid component).

@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 12, 2024
@ThomThomson ThomThomson added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:medium Medium Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Project:Collapsable Panels Related to the project for adding collapsable sections to Dashboards. Feature:Dashboard Dashboard related features and removed needs-team Issues missing a team label labels Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:Collapsable Panels Related to the project for adding collapsable sections to Dashboards. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

1 participant