Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Placeholder “Semver” Appears in the Related Integrations “Version” Text Field in Rule Upgrade Flyout #200079

Open
Tracked by #179907
pborgonovi opened this issue Nov 13, 2024 · 4 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@pborgonovi
Copy link
Contributor

pborgonovi commented Nov 13, 2024

Describe the bug:
In the Upgrade Flyout under the “Related integrations” section, the placeholder “Semver” is displayed in the “Version” text field.

Kibana/Elasticsearch Stack version:
8.x

Current branch: 8.x  
Latest commit: ecae27e4444 - [8.x] [Index Mgmt] Improve accessibility of templates table (#199980) (#200031)  
Remote tracking: origin/8.x  
Status relative to remote: up to date (no pending commits)  

Server OS version:

Browser and Browser OS versions:

Elastic Endpoint version:

Original install method (e.g. download page, yum, from source, etc.):

Functional Area (e.g. Endpoint management, timelines, resolver, etc.):
Prebuilt Rules Upgrade

Pre requisites:

  1. Have an older rules package installed (e.g. 8.15.4)
  2. Have prebuilt rules installed
  3. One of installed rules must have diff in integrations (e.g. Image File Execution Options Injection)

Steps to reproduce:

  1. Upgrade rules package to the latest version
  2. Go to Rule Updates table
  3. Select the rule with diff in integrations
  4. In the Upgrade Flyout, select 'Edit' under Related Integrations section
  5. Remove value from a field 'Version'

Current behavior:
The “Version” field displays “Semver” as a placeholder

Expected behavior:
The placeholder in the “Version” field should provide clear guidance, such as:

  • “Enter a version”
  • “e.g., ^1.0.0”

Screenshots (if relevant):

Image

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context (logs, chat logs, magical formulas, etc.):

@pborgonovi pborgonovi added bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team triage_needed labels Nov 13, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@banderror
Copy link
Contributor

banderror commented Nov 22, 2024

@pborgonovi Great catch! I think there's a bigger issue here.

The abnormal_security integration that was (if I understand correctly) added to the list of related integrations in the target version, has "version": "0.0.0" which I'm pretty sure doesn't exist. The UI handles this case by resetting the whole related integration, so the user has to re-add it manually.

I would suggest that UI should keep what is in the data and never change it on its own. Only the user should change it. And any invalid values potentially coming from the data should be blocked by validation.

Since this is a low-impact UX issue and an edge case, I will add this bug to Milestone 4.

cc @maximpn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Development

No branches or pull requests

3 participants