Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate sample data installer off of the saved objects APIs #200781

Open
TinaHeiligers opened this issue Nov 19, 2024 · 6 comments
Open

Migrate sample data installer off of the saved objects APIs #200781

TinaHeiligers opened this issue Nov 19, 2024 · 6 comments
Labels
Epic:Deprecations Deprecations Feature:Add Data Add Data and sample data feature on Home Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@TinaHeiligers
Copy link
Contributor

TinaHeiligers commented Nov 19, 2024

Related to #149287
Installing sample data uses the Saved Objects APIs.
We need to audit the implementation and migrate off of deprecated APIs before they are removed.

Migration options:

  1. Use public domain specific APIs
  2. Rely only on import/export
  3. something else
@TinaHeiligers TinaHeiligers added Epic:Deprecations Deprecations Feature:Add Data Add Data and sample data feature on Home Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Nov 19, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@TinaHeiligers
Copy link
Contributor Author

Initial audit:

  1. run kibana, install sample data and record deprecation logs related to Saved Objects
  2. audit the code for deprecations
  3. document which (if any) deprecated APIs are used
  4. discuss migration options

@rudolf
Copy link
Contributor

rudolf commented Nov 20, 2024

As far as I can tell the only usage is https://github.com/elastic/kibana/blob/main/src/plugins/home/public/application/components/home_app.js#L64

This could probably be ported to use the import saved objects API

@rudolf rudolf added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Nov 20, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@rudolf rudolf removed the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Nov 20, 2024
@Dosant
Copy link
Contributor

Dosant commented Nov 25, 2024

@TinaHeiligers, @rudolf thanks for taking a look. We will look into this, but I wonder if this is needed for 9.0 and should be tracked together with other 9.0 blocking items?

@rudolf
Copy link
Contributor

rudolf commented Nov 26, 2024

We are no longer removing saved object APIs from 9.0 and so this is more general cleanup work than a 9.0 blocker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic:Deprecations Deprecations Feature:Add Data Add Data and sample data feature on Home Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Development

No branches or pull requests

4 participants