Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Changes in Final Column Persist After Dismissal but Are Lost Upon Navigating Tabs #202799

Open
Tracked by #179907
pborgonovi opened this issue Dec 3, 2024 · 4 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@pborgonovi
Copy link
Contributor

Describe the bug:

Changes made to the Final column in the rule update flyout persist after clicking the “Dismiss” button. However, these changes are lost if the user navigates to another tab and then returns to the Updates tab.

Kibana/Elasticsearch Stack version:

8.x

Current branch: 8.x  
Latest commit: f3da0dccd45 - [8.x] [Automatic Import] Add base for ftr api tests (#200169) (#202752)  
Remote tracking: origin/8.x  
Status relative to remote: up to date (no pending commits)  

Server OS version:

Browser and Browser OS versions:

Elastic Endpoint version:

Original install method (e.g. download page, yum, from source, etc.):

Functional Area (e.g. Endpoint management, timelines, resolver, etc.):

Pre requisites:

  1. Feature flag prebuiltRulesCustomizationEnabled is ON
  2. Rules are installed
  3. Rules updates are available

Steps to reproduce:

  1. Navigate to the Updates tab and open one rule update flyout.
  2. Edit any field in the Final column.
  3. Click the Dismiss button to close the flyout.
  4. Navigate to another tab (e.g. Installed Rules).
  5. Return to the Updates tab and reopen the flyout.

Current behavior:

  • Changes made to the Final column persist when the flyout is dismissed and reopened without leaving the Updates tab.
  • Changes are lost after navigating to another tab and returning to the Updates tab.

Expected behavior:

Either persist the changes consistently, even after navigating to other tabs or discard all unsaved changes upon clicking Dismiss, ensuring a reset state.

Screenshots (if relevant):

Screen.Recording.2024-12-03.at.10.54.30.AM.mov

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context (logs, chat logs, magical formulas, etc.):

@pborgonovi pborgonovi added bug Fixes for quality problems that affect the customer experience Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team triage_needed labels Dec 3, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@banderror
Copy link
Contributor

@pborgonovi I agree that it's not an ideal behavior. We'll fix it later. Since it's low-impact it goes to Milestone 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Development

No branches or pull requests

3 participants