-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooltips in EuiBasicTable headers #20663
Comments
@cchaos you've mentioned before that maybe we should build in specific support for table header tooltips. Any thoughts here? |
I've talked about needing to add I know the final |
Yes, either that or ability to specify a string that will be displayed as a tooltip. Do you have any preference between the two? |
Wow. I just realized now that I created this in kibana instead of eui. Brainfart! I'll move it over... |
Moved to elastic/eui#1002 |
Allowing nodes is the most flexible, as you mentioned. I would vote for that solution. |
Oops, page didn't fully refresh. I'll move over to the EUI issue. |
@alvarolobato Did you reopen this on purpose, or is it Zube doing funny things? |
With KUI Tables it was possible to add tooltips to the header cells. This is useful since some columns need to be explained to the user. In APM we have a column called "Impact" with a tooltip saying:
Impact shows the most used and slowest endpoints in your service
.Implementation
Option A)
EuiBasicTable
currently only support strings asname
. By allowing allowing custom elements like, it would be possible to customize the header in a very flexible way:Option B) Another option is to keep the
name
field limited to strings, but introduce atooltip
field:The advantage of A is that it is very flexible and allows for many use cases that EUI doesn't have to specifically implement. The disadvantage is that it can reduce the consistency of tables across Kibana.
The advantage of B is that it will make it very easy to add tooltips, and it enforces the consistency of Kibana. The disadvantage is that is not very flexible.
Personally I'm learning more towards B. it seems like a generic feature that many would benefit from having in a standardized way.
The text was updated successfully, but these errors were encountered: