Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Moving Average pipeline aggregation #24702

Closed
2 tasks done
timroes opened this issue Oct 27, 2018 · 4 comments
Closed
2 tasks done

Replace Moving Average pipeline aggregation #24702

timroes opened this issue Oct 27, 2018 · 4 comments
Labels
blocker Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0

Comments

@timroes
Copy link
Contributor

timroes commented Oct 27, 2018

The moving average pipeline aggregation has been deprecated as of 6.4: https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-pipeline-movavg-aggregation.html

We need to replace it with the new Moving Function aggregation instead.

This needs to be replaced in

Timelion's moving average is implemented in the Kibana server, and does not use the moving_avg ES function.

cc @elastic/kibana-app

@timroes timroes added blocker Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) v7.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 27, 2018
@timroes timroes added v8.0.0 and removed v7.0.0 labels Nov 12, 2018
@markov00 markov00 added the Feature:TSVB TSVB (Time Series Visual Builder) label May 2, 2019
@markov00
Copy link
Member

markov00 commented May 2, 2019

cc @elastic/kibana-tsvb-external

@markov00
Copy link
Member

markov00 commented May 3, 2019

Hey @timroes, after a first review with @alexwizp on TSVB the refactoring will be a bit more complex.
On TSVB we have UI options for configure some parameters like minimize, predict that are no more available in the moving function (elastic/elasticsearch#29594 for reference)

The question is how to threat those parameters, my ideas are:

  • we should remove them from the UI
  • we should include a migration that nicely fallback to an existing property/moving function function

How can we make the user aware that, after migration, some visualization may have been changed?

@timroes
Copy link
Contributor Author

timroes commented May 3, 2019

@markov00 I agree with you: Let's remove them from the UI and write a migration that will actually remove them (convert them) from existing saved objects. I think it's enough for us to highlight that in the release notes of the respective version.

@gospodarsky
Copy link

Closed #36624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0
Projects
None yet
Development

No branches or pull requests

3 participants