Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Should introduce CSS prefixes to their selectors #25691

Open
snide opened this issue Nov 15, 2018 · 2 comments
Open

[ML] Should introduce CSS prefixes to their selectors #25691

snide opened this issue Nov 15, 2018 · 2 comments
Labels
:ml Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@snide
Copy link
Contributor

snide commented Nov 15, 2018

ML contains a lot of generic naming .disabled, .status and naked selectors div, label, span in its styling layer. To avoid breaking Kibana this was somewhat negated with an #ml-app top level scope. Until the individual selectors are prefixed ML itself though will always remain vulnerable to imported dependencies or outside plugins that likely share the same generic naming (and hence break ML).

Currently all EUI and Kibana Sass uses a three-letter prefix for its naming per app to help avoid these kinds of conflicts. ML will need to introduce something similar to their code (whatever that may be).

By 7.0 the design team will introduce linting into Kibana's Sass files similar to the rules in EUI. It will check for some manner of prefixing and name-spacing.

At a later date (when the frontend is fully react) auto-prefixing through CSS modules will be a less brittle solution for namespace conflicts.

@snide snide added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. :ml labels Nov 15, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@walterra walterra self-assigned this Nov 15, 2018
@walterra walterra removed their assignment Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Development

No branches or pull requests

3 participants