Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reporting] Chromium headless browser should not send telemetry #41402

Closed
tsullivan opened this issue Jul 17, 2019 · 13 comments · Fixed by #100388
Closed

[Reporting] Chromium headless browser should not send telemetry #41402

tsullivan opened this issue Jul 17, 2019 · 13 comments · Fixed by #100388
Assignees
@tsullivan
Labels
blocked bug Fixes for quality problems that affect the customer experience (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Feature:Reporting:Framework Reporting issues pertaining to the overall framework impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort needs-team Issues missing a team label

Comments

@tsullivan
Copy link
Member

Kibana version:
8.0.0/master

Elasticsearch version:
8.0.0/master

Describe the bug:
Seen in the verbose logs while Chromium was taking a long time to generate the screenshot of the page:

server    log   [12:23:03.913] [debug][browser-driver][chromium-driver-factory][headless-chromium-driver][reporting] Using custom headers for https://spicy.local/kbn/api/telemetry/v2/clusters/_stats
server    log   [12:23:04.208] [debug][browser-driver][chromium-driver-factory][headless-chromium-driver][reporting] No custom headers for https://telemetry-staging.elastic.co/xpack/v2/send
server    log   [12:23:04.376] [debug][browser-driver][chromium-driver-factory][headless-chromium-driver][reporting] No custom headers for https://telemetry-staging.elastic.co/xpack/v2/send

Having Chromium attempt to send telemetry/phone home stats seems risky, because if there is a block in the outgoing connection, Reporting might see that as a reason to fail the entire reporting job.
@tsullivan tsullivan added bug Fixes for quality problems that affect the customer experience (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Team:Stack Services labels Jul 17, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-services

@tsullivan
Copy link
Member Author

@Bamieh can you think of any way we can suppress sending telemetry from the browser, only for the headless Chromium used for Reporting?

@bmcconaghy
Copy link
Contributor

@tsullivan one thought I have is you could start the browser with the entry in local storage for "date last sent" that reporting uses to decide whether or not to send set to when you start the browser so that it skips sending.

@tsullivan
Copy link
Member Author

@bmcconaghy that seems worth a shot! I'll try that out. I'd hate it if telemetry communications ever would cause a screenshot capturing job to fail.

@tsullivan
Copy link
Member Author

I played around with the proposed solution briefly a few days ago, but haven't had luck in seeing it work yet.

@tsullivan tsullivan self-assigned this Sep 20, 2019
@tsullivan tsullivan changed the title [Reporting] Chromium headless browser should probably never send telemetry [Reporting] Chromium headless browser should not send telemetry Oct 1, 2019
@tsullivan
Copy link
Member Author

PR in flight: #48312

@tsullivan
Copy link
Member Author

#48312 was merged, but I have still found telemetry requests occasionally sent when looking at the debug request logs of a reporting job.

@bmcconaghy bmcconaghy added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) and removed Team:Stack Services labels Dec 12, 2019
@bmcconaghy bmcconaghy added Team:Reporting Services and removed Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Dec 20, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@tsullivan
Copy link
Member Author

This is blocked on having some kind of UI Service that the Telemetry plugin could depend on to notify when the page is rendering for screenshot purposes only.

@Bamieh Bamieh mentioned this issue Mar 4, 2021
Closed
@Bamieh
Copy link
Member

Bamieh commented Mar 4, 2021

@tsullivan I opened an issue for the core team to follow up on and prioratize to unblock

@tsullivan
Copy link
Member Author

@Bamieh see #93496

@ppisljar ppisljar added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort labels Apr 29, 2021
@tsullivan
Copy link
Member Author

Depends on #99011

@exalate-issue-sync exalate-issue-sync bot added loe:small Small Level of Effort and removed loe:medium Medium Level of Effort labels May 13, 2021
@jloleysens jloleysens mentioned this issue May 20, 2021
Merged
1 task
@sophiec20 sophiec20 added Feature:Reporting:Framework Reporting issues pertaining to the overall framework and removed (Deprecated) Team:Reporting Services labels Aug 21, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsullivan tsullivan

Labels
blocked bug Fixes for quality problems that affect the customer experience (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Feature:Reporting:Framework Reporting issues pertaining to the overall framework impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort needs-team Issues missing a team label
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Reporting/Telemetry] Do not send telemetry if we are in screenshot mode jloleysens/kibana
7 participants
@tsullivan @bmcconaghy @sophiec20 @Bamieh @ppisljar @elasticmachine @petrklapka