Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph vertex type configurator and vertex type list re-styling #44104

Closed
flash1293 opened this issue Aug 27, 2019 · 7 comments
Closed

Graph vertex type configurator and vertex type list re-styling #44104

flash1293 opened this issue Aug 27, 2019 · 7 comments
Labels
Feature:Graph Graph application feature Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

The current editor for vertex types in graph is not a good fit for EUI components and should get re-styled during EUI-fication.

Screenshot 2019-08-27 at 17 05 44

Screenshot 2019-08-27 at 17 07 12

Ideas:

  • Move editor to a flyout or to a popover
  • Show field names instead of just icon
  • Make "new vertex type" button more prominent
  • Make icon optional
@flash1293 flash1293 added Feature:Graph Graph application feature Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 27, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@flash1293
Copy link
Contributor Author

@monfera @cchaos What do you think about this layout (just a mock at the moment)?

Screenshot 2019-09-02 at 14 56 13

Should I go forward with this approach?

@cchaos
Copy link
Contributor

cchaos commented Sep 3, 2019

I think this is a great start and interim re-design. Just had a couple of suggestions.

(edit) added a redpen for feedback - all feedback welcomed, please contribute.

@flash1293
Copy link
Contributor Author

Very good suggestions, thanks. I will put up a real PR with these fixes. I forgot one thing in the mockup - you can also disable a vertex type, I think I will put a switch for that in the flyout, not sure how to reflect it in the badge though - a color saturation filter might not be enough if the user can freely pick a color, maybe crossing it out like for filters on dashboards?

@shaunmcgough
Copy link

@flash1293 @cchaos @monfera What do you think about having a little checkbox inside the badge that can enable / disable this? It adds some width, but is accessible and heads up.

@flash1293
Copy link
Contributor Author

Nice idea @shaunmcgough I will work on a PR for this as the next step, then we can iterate there.

@flash1293
Copy link
Contributor Author

Done via #45384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Graph Graph application feature Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants