-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graph vertex type configurator and vertex type list re-styling #44104
Comments
Pinging @elastic/kibana-app |
I think this is a great start and interim re-design. Just had a couple of suggestions. (edit) added a redpen for feedback - all feedback welcomed, please contribute. |
Very good suggestions, thanks. I will put up a real PR with these fixes. I forgot one thing in the mockup - you can also disable a vertex type, I think I will put a switch for that in the flyout, not sure how to reflect it in the badge though - a color saturation filter might not be enough if the user can freely pick a color, maybe crossing it out like for filters on dashboards? |
@flash1293 @cchaos @monfera What do you think about having a little checkbox inside the badge that can enable / disable this? It adds some width, but is accessible and heads up. |
Nice idea @shaunmcgough I will work on a PR for this as the next step, then we can iterate there. |
Done via #45384 |
The current editor for vertex types in graph is not a good fit for EUI components and should get re-styled during EUI-fication.
Ideas:
The text was updated successfully, but these errors were encountered: