Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Copy over TimeBuckets into ML code #44249

Closed
timroes opened this issue Aug 28, 2019 · 2 comments · Fixed by #46227
Closed

[ML] Copy over TimeBuckets into ML code #44249

timroes opened this issue Aug 28, 2019 · 2 comments · Fixed by #46227
Assignees

Comments

@timroes
Copy link
Contributor

timroes commented Aug 28, 2019

ML is currently making heavy usage of TimeBuckets (ui/time_buckets). In preparation for the new platform this will become part of the data plugin, but we don't want to expose it as an API, since it's more like an implementation detail of how AggConfigs work. Also we are planning to do some refactoring around it, that might break it's API. Since we're not considering this to be an API in the future, and you want to keep using it, I would like to ask you to copy over the relevant code (basically the ui/public/time_buckets folder) into the ML plugin, so we can in the future just remove access to that code for anything outside the data plugin, and also are not destroying ML code while changing the TimeBuckets functionality.

This is not a super urgent matter, but it would be good if this could happen sometime until around the 7.5 release.

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@peteharverson peteharverson changed the title Copy over TimeBuckets into ML code [ML] Copy over TimeBuckets into ML code Aug 28, 2019
@peteharverson
Copy link
Contributor

@timroes thanks for raising this. We will schedule this for 7.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants