Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint rule to forbid importing server code from public code #49053

Closed
pgayvallet opened this issue Oct 23, 2019 · 1 comment · Fixed by #52447
Closed

Add eslint rule to forbid importing server code from public code #49053

pgayvallet opened this issue Oct 23, 2019 · 1 comment · Fixed by #52447
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@pgayvallet
Copy link
Contributor

Importing server bits from client code can be very dangerous and heavy in term of side effects, unexpected behaviour and bundle size. This is something that should be explicitly forbidden and needs an eslint check.

Exemple: in src/plugins/kibana_react/public/saved_objects/saved_object_finder.tsx:
import { SavedObjectAttributes } from '../../../../core/server';

We should probably be able to re-use @kbn/eslint/no-restricted-paths for this
@pgayvallet pgayvallet added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Oct 23, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@pgayvallet pgayvallet changed the title Add eslint rule to forbit importing server code from public code Add eslint rule to forbid importing server code from public code Oct 23, 2019
@pgayvallet pgayvallet mentioned this issue Nov 28, 2019
Merged
2 tasks
This was referenced Dec 7, 2019
Merged
Merged
@joshdover joshdover mentioned this issue Dec 13, 2019
Closed
@jfsiii jfsiii mentioned this issue Dec 30, 2019
Merged
This was referenced Jan 3, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add lint rule to prevent server code being imported into client joshdover/kibana
2 participants
@pgayvallet @elasticmachine