-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Add message
fields to metadata table
#49465
Comments
Pinging @elastic/apm-ui (Team:apm) |
Blocked until elastic/apm-server#2697 is implemented |
@alvarolobato Just a heads up; we have this implementation issue re: the message fields from the Java agent. I added this to the Observability roadmap spreadsheet too. |
@sqren Although it's currently blocked waiting for server changes, this is targeted for 7.6 so I've added that label and put it in the lane for 7.6 planned items. |
Thanks @formgeist |
@sqren @formgeist I think this issue is not blocked, as we can still add those fields to the metadata table, the only point is that they would only show up after the Java agent is implemented. And if one of them is required, the empty message will show instead. |
Looks like the PR is merged so it's unblocked elastic/apm-agent-java#906 |
@formgeist Great that java support has landed! Although think we'll need server support as well before the UI can start consuming this elastic/apm-server#2697 @cauemarcondes True, we could start without data. Historically we've just seen how implementing features without proper data is more error prone and takes more time. So generally we try to postpone implementation until the data is available. |
There's a new field being added to the |
There is an intention to use |
@eyalkoren we'll show everything inside |
Summary
Related to the Java agent implementing messaging data (elastic/apm#143), we want to add those fields to the metadata tab (when available).
Field names in elasticsearch:
transaction.message
span.message
Solution
Message
section to the metadata table for Transactions and SpansProcess
andAgent
sections https://github.com/elastic/kibana/blob/master/x-pack/legacy/plugins/apm/public/components/shared/MetadataTable/TransactionMetadata/sections.ts#L7Service
andAgent
sections https://github.com/elastic/kibana/blob/master/x-pack/legacy/plugins/apm/public/components/shared/MetadataTable/SpanMetadata/sections.ts#L17For(postponed for the first iteration)context.message.age.ms
, we expect the calculation to be an estimate more than an accurate measurement; therefore we need to treat0
and possibly surrounding values (negative and positive) as~0
. Please refer to the original comment in the meta issue.The text was updated successfully, but these errors were encountered: