Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Add message fields to metadata table #49465

Closed
2 tasks
formgeist opened this issue Oct 28, 2019 · 11 comments · Fixed by #54017
Closed
2 tasks

[APM] Add message fields to metadata table #49465

formgeist opened this issue Oct 28, 2019 · 11 comments · Fixed by #54017
Assignees
Labels
blocked Team:APM All issues that need APM UI Team support v7.6.0

Comments

@formgeist
Copy link
Contributor

formgeist commented Oct 28, 2019

Summary

Related to the Java agent implementing messaging data (elastic/apm#143), we want to add those fields to the metadata tab (when available).

Field names in elasticsearch:

  • transaction.message
  • span.message

Solution

@formgeist formgeist added the Team:APM All issues that need APM UI Team support label Oct 28, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv
Copy link
Member

Blocked until elastic/apm-server#2697 is implemented

@formgeist
Copy link
Contributor Author

@alvarolobato Just a heads up; we have this implementation issue re: the message fields from the Java agent. I added this to the Observability roadmap spreadsheet too.

@formgeist
Copy link
Contributor Author

@sqren Although it's currently blocked waiting for server changes, this is targeted for 7.6 so I've added that label and put it in the lane for 7.6 planned items.

@sorenlouv
Copy link
Member

Thanks @formgeist

@cauemarcondes
Copy link
Contributor

@sqren @formgeist I think this issue is not blocked, as we can still add those fields to the metadata table, the only point is that they would only show up after the Java agent is implemented. And if one of them is required, the empty message will show instead.

@formgeist
Copy link
Contributor Author

Looks like the PR is merged so it's unblocked elastic/apm-agent-java#906

@formgeist formgeist removed the blocked label Nov 18, 2019
@sorenlouv
Copy link
Member

sorenlouv commented Nov 18, 2019

@formgeist Great that java support has landed! Although think we'll need server support as well before the UI can start consuming this elastic/apm-server#2697

@cauemarcondes True, we could start without data. Historically we've just seen how implementing features without proper data is more error prone and takes more time. So generally we try to postpone implementation until the data is available.

@formgeist
Copy link
Contributor Author

There's a new field being added to the message context, so I've updated the description.

@eyalkoren
Copy link
Contributor

There is an intention to use context.message.age.ms for doing some aggregation and add it to the Trace metadata, and this part was postponed to a later step.
However, this field may be useful as is in the span/transaction span details, so worth adding it in the first iteration without any special handling.

@sorenlouv
Copy link
Member

@eyalkoren we'll show everything inside message (so also age.ms). @cauemarcondes already implemented this in #54017 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Team:APM All issues that need APM UI Team support v7.6.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants