Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual testing improve baselines #52026

Closed
liza-mae opened this issue Dec 2, 2019 · 6 comments
Closed

Visual testing improve baselines #52026

liza-mae opened this issue Dec 2, 2019 · 6 comments
Assignees

Comments

@liza-mae
Copy link
Contributor

liza-mae commented Dec 2, 2019

We need to improve how our baselines are done for visual testing to keep the baseline for PRs from updating to latest, as is the case here:

This change was checked in with an icon update and caused failures across PRs that were based prior to the update:
#51696

Example:
https://percy.io/elastic/kibana/builds/3325533

With existing tool we would have to see if we can do something custom, some examples were sent.

@liza-mae liza-mae added Feature:Visual Testing Team:Operations Team label for Operations Team labels Dec 2, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@spalger spalger self-assigned this Dec 5, 2019
@liza-mae
Copy link
Contributor Author

I believe the PR for this is:
#52154

I pinged Spencer this morning, that we are waiting on review.

Spencer, can you update ETA for it?

Thanks!

@liza-mae
Copy link
Contributor Author

@tylersmalley @spalger can we reassess moving the expected delivery date up on this?
I see it has been moved to 7.9, I would like to aim for something sooner. Let me know what still needs to be done and what the road blocks are? Thanks!

@liza-mae
Copy link
Contributor Author

cc: @mdelapenya

@tylersmalley
Copy link
Contributor

@liza-mae @spalger, is this issue still necessary? Are we still doing visual testing?

@liza-mae
Copy link
Contributor Author

@tylersmalley we may still do some visual testing, however we can close this particular issue as it is out of date now. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants