-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual testing improve baselines #52026
Comments
Pinging @elastic/kibana-operations (Team:Operations) |
I believe the PR for this is: I pinged Spencer this morning, that we are waiting on review. Spencer, can you update ETA for it? Thanks! |
@tylersmalley @spalger can we reassess moving the expected delivery date up on this? |
cc: @mdelapenya |
@tylersmalley we may still do some visual testing, however we can close this particular issue as it is out of date now. Thanks. |
We need to improve how our baselines are done for visual testing to keep the baseline for PRs from updating to latest, as is the case here:
This change was checked in with an icon update and caused failures across PRs that were based prior to the update:
#51696
Example:
https://percy.io/elastic/kibana/builds/3325533
With existing tool we would have to see if we can do something custom, some examples were sent.
The text was updated successfully, but these errors were encountered: