Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discuss][Data Views] Field popularity performance improvement #52318

Closed
Tracked by #170754
streamich opened this issue Dec 5, 2019 · 6 comments
Closed
Tracked by #170754

[Discuss][Data Views] Field popularity performance improvement #52318

streamich opened this issue Dec 5, 2019 · 6 comments
Labels
discuss Feature:Data Views Data Views code and UI - index patterns before 8.0 Icebox impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort performance Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@streamich
Copy link
Contributor

streamich commented Dec 5, 2019

Index Pattern service discussion mentions that field popularity (or "count") is used only in Discover:

Seems to only be used in discover to sort some fields to the top of the list

Now index pattern is saved every time a user does some field related operation in Discover. Like pressing the "add" or "remove" button on the field. Customer has suggested to improve how field popularity is tracked:

Should popularity be stored in elasticsearch? I think it might be better to manage it on local storage for now If concurrent users are not considered as now.

Even if it should be stored in elasticsearch as-is for sharing popularity, it doesn't seem desirable to update a full index pattern each time. How about making dedicated API for updating popularity, keep it temporarily in memory, and update it periodically?

What do we want to do about field popularity?

@streamich streamich added discuss Team:Visualizations Visualization editors, elastic-charts and infrastructure Team:AppArch labels Dec 5, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lukeelmers
Copy link
Member

Leave as is, but suppress warnings on concurrent updates. #52266

++ I think this is a great way to minimize confusion while we sort out a longer-term strategy.

Abandon them completely and rethink Index Pattern service. #35481

In the past we have discussed the idea of a more thorough "field statistics" service offered as a part of index patterns. AFAIK the design of such a service hasn't been discussed in much detail yet, but presumably would replace the existing indexPattern.popularizeField() method.

Also FWIW, field popularity feels thematically related to the long-standing discussion around usage metrics in Kibana. If a feature like that were eventually implemented, then we could consider rolling field popularity tracking into it as another option. (If it is, in fact, something that users want/need).

@ppisljar ppisljar added Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated labels May 10, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:small Small Level of Effort and removed loe:needs-research This issue requires some research before it can be worked on or estimated labels Jun 21, 2021
@flash1293 flash1293 added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 7, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@lizozom
Copy link
Contributor

lizozom commented Nov 3, 2021

I recently noticed that when authoring runtime fields and having discover open in another tab, saving runtime fields would occasionally fail and require a refresh, because the index pattern is out of sync. This explains why this happens.

Probably worth considering that usecase as well when thinking of a solution.

@lizozom lizozom changed the title [Discuss] [Index Patterns] Field popularity performance improvement [Discuss][Data Views] Field popularity performance improvement Nov 10, 2021
@kertal kertal added the Icebox label Nov 27, 2023
@kertal
Copy link
Member

kertal commented Nov 27, 2023

Closing this because it's not planned to be resolved in the foreseeable future. It will be tracked in our Icebox and will be re-opened if our priorities change. Feel free to re-open if you think it should be melted sooner.

@kertal kertal closed this as not planned Won't fix, can't repro, duplicate, stale Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Feature:Data Views Data Views code and UI - index patterns before 8.0 Icebox impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort performance Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

9 participants