Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor kibana-react context #52494

Closed
5 tasks
streamich opened this issue Dec 9, 2019 · 3 comments
Closed
5 tasks

Refactor kibana-react context #52494

streamich opened this issue Dec 9, 2019 · 3 comments
Assignees
Labels
Feature:Development Feature:kibana-react impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort refactoring Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@streamich
Copy link
Contributor

streamich commented Dec 9, 2019

  • Refactor kibana-react global context
    • Remove .notifications and .overlays objects from context.
    • Lift .services object up.
    • Possibly add useNotifications and useOverlays hooks instead of .overlays and .notifications objects.
  • Update docs to remove examples of passing all of core to the provider
    • As discussed in [discuss] Direct dependency on NP code in low-level components...? #53029, passing all of core to the provider encourages tight coupling to the UI, which can be problematic, and we want to avoid recommending this to devs.
    • Examples using this approach should be removed from the docs; instead we should only show examples where pieces of core are explicitly passed to the provider.
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lukeelmers
Copy link
Member

I'm tracking remaining new platform migration items over in #51560, and one of those includes proposed updates to kibana_react based on the discussion in #53029.

Should we include those in the scope of this issue, or track separately?

@streamich streamich added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort refactoring labels May 4, 2021
@Dosant Dosant added Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) and removed Team:AppServicesSv labels Mar 16, 2022
@ppisljar
Copy link
Member

ppisljar commented Aug 8, 2022

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@ppisljar ppisljar closed this as completed Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Development Feature:kibana-react impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort refactoring Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Development

No branches or pull requests

5 participants