-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] [Discuss] How should users configure pipeline functions such as cumulative sum, derivative? #56696
Comments
Pinging @elastic/kibana-app (Team:KibanaApp) |
I think it's important to say that these are the functions that are useful to run on pre-aggregated data, which is a different editing model than most other tools we're familiar with. There are three categories that we would likely support, which are roughly matching Elasticsearch functions:
What kind of visualization do we want users to make using these broad categories?
|
@AlonaNadler Are there specific visualizations you expect users to build using pipeline functions? |
From a UI perspective, @AlonaNadler and I have decided that these aggregations (under the Quick Functions umbrella) should only entail one level of nesting. Therefore, the only thing different between them and a normal (sum, avg, etc) aggregation, is the addition of a Anything more complicated than this would fall under the "Builder" tab which is for another discussion. |
@cchaos You have mocked up an example for a "Window/Map" type function, but I don't think you've addressed the other two types: Filter and Reduce functions. |
What aggregations (that exist in Kibana) are those related to? I need more examples of how you create them not the logic behind them. Examples from TSVB or visualize help the most. |
Sure, examples follow. Filters: Reduce:
|
If possible @wylieconlon, to start let's focus on 4 types of pipeline aggregation first:
*All the aka "overall" aggregation needs a different approach as well where on top of a chart users want to calculate an overall. I'm not sure just listing them as a function will be the right way to go, even though they are pipeline aggregations. The ideal solution to me is to add an overall metric when a xy as a metric alongside the chart or if in donut to add for example overall average in the center.
|
@AlonaNadler Thanks for the priorities! I agree that these window functions are the easiest ones to start with. Even if we start with the window functions, we can't begin implementing this without considering the other two types, because those other two types are already supported by TSVB and Visualize. I'm also hoping that by looking closely at what TSVB supports will give us ideas on how to improve Lens. For example, TSVB is trying to make complicated functions user-friendly by exposing "Filter Ratio", "Math", "Bucket Std. Deviation", and others. Are the functions exposed in TSVB done well? How would that work in Lens? |
Here are some mocks for the aggregations that @AlonaNadler mentioned: Cumulative sumDerivative (Percent difference would behave the same)Moving average |
I never got an answer to the question I was originally asking, and given that there hasn't been any more followup on this I'm going to close it without the answer. I will try another set of techniques to get the feedback that is needed. |
Elasticsearch offers a set of pipeline aggregations which take aggregated data and perform another set of calculations on the response. Based on the requirements for our use in Lens, we might extend this concept with our own "pipeline-like" functions- a good example might be percentages or filter ratios.
Kibana users see two interfaces that wrap this concept already. Should Lens use one of these patterns, or a third pattern?
The patterns are:
Let's discuss the pros and cons of these options, and if neither of them is applicable, come up with a new pattern.
The text was updated successfully, but these errors were encountered: