Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API key gets created for disabled alerts (update API) #57099

Closed
mikecote opened this issue Feb 7, 2020 · 1 comment · Fixed by #57102
Closed

API key gets created for disabled alerts (update API) #57099

mikecote opened this issue Feb 7, 2020 · 1 comment · Fixed by #57102
Assignees
@mikecote
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.7.0

Comments

@mikecote
Copy link
Contributor

mikecote commented Feb 7, 2020

Similar to #57036. API keys get generated when calling the update API and the alert is disabled.

The following code shouldn't create an API key when the alert is disabled:

kibana/x-pack/legacy/plugins/alerting/server/alerts_client.ts

Line 290 in 8aa2b61

const apiKeyAttributes = this.apiKeyAsAlertAttributes(await this.createAPIKey(), username);

@mikecote mikecote added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Feb 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote mikecote self-assigned this Feb 7, 2020
This was referenced Feb 7, 2020
Merged
Merged
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikecote mikecote

Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't create API key for disabled alerts when calling update API mikecote/kibana
3 participants
@kobelb @mikecote @elasticmachine