Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

visualizations: toExpression function #61829

Closed
ppisljar opened this issue Mar 30, 2020 · 3 comments
Closed

visualizations: toExpression function #61829

ppisljar opened this issue Mar 30, 2020 · 3 comments
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Feature:Visualizations Generic visualization features (in case no more specific feature label is available)

Comments

@ppisljar
Copy link
Member

ppisljar commented Mar 30, 2020 •
edited
Loading

currently we build expressions for visualizations in build_pipeline.ts by concatenating strings. It has two problems:

  • string concatenation is easy to break and hard to test
  • impossible to extend (for 3rd party visualizations)

we should add toExpression or toAST function to visualization definition which accepts VisParams and returns correct AST.

parent issue: #59598
@ppisljar ppisljar added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:AppArch labels Mar 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@ppisljar ppisljar mentioned this issue Mar 30, 2020
Closed
11 tasks
@streamich streamich mentioned this issue Mar 30, 2020
Closed
20 tasks
@streamich
Copy link
Contributor

Seems to be duplicate of #51246

@lukeelmers
Copy link
Member

yes, i think this is a duplicate. will close.

This was referenced May 5, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Feature:Visualizations Generic visualization features (in case no more specific feature label is available)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lukeelmers @streamich @ppisljar @elasticmachine