Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest] Adjust validation UI on data source configuration fields #63070

Closed
jen-huang opened this issue Apr 8, 2020 · 3 comments · Fixed by #71187
Closed

[Ingest] Adjust validation UI on data source configuration fields #63070

jen-huang opened this issue Apr 8, 2020 · 3 comments · Fixed by #71187
Assignees
@jen-huang
Labels
design Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@jen-huang
Copy link
Contributor

Following the work done in #61180 and #62858, we need to update the validation UI to match design. Here are some additional design notes from @hbharding. Note that the screenshot below shows the form error as a red callout at bottom of page. This should be removed in favor of putting the form error on the bottom bar instead.

image

View in Figma
@jen-huang jen-huang added Team:Fleet Team label for Observability Data Collection Fleet team Ingest Management:alpha1 Group issues for ingest management alpha1 labels Apr 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@jen-huang jen-huang mentioned this issue Apr 8, 2020
Closed
22 tasks
@jen-huang jen-huang added design Ingest Management:beta1 and removed Ingest Management:alpha1 Group issues for ingest management alpha1 labels Apr 28, 2020
@jen-huang
Copy link
Contributor Author

@ruflin As these are UI-only adjustments, I'm going to kick this one to beta, hope you don't mind.

@hbharding Would be great to update the mockup for Beta that includes having the general error in bottom bar.

@jen-huang jen-huang assigned jen-huang and unassigned jen-huang Jul 9, 2020
@jen-huang jen-huang assigned hbharding and jen-huang and unassigned hbharding Jul 9, 2020
@jen-huang jen-huang mentioned this issue Jul 10, 2020
Merged
@jen-huang
Copy link
Contributor Author

@hbharding FYI I implemented this in #71187, you can see some screenshots in the PR description. It differs from the mockup here since the overall design of Add/Edit integration changed. There is no red border in the implemented UI, and the callout message was moved to the bottom bar instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jen-huang jen-huang

Labels
design Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Ingest Manager] Simplify add/edit package config (integration) form jen-huang/kibana
3 participants
@hbharding @jen-huang @elasticmachine