Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Editing APM alerts via Generic Alerting UI is not possible #65399

Closed
smith opened this issue May 5, 2020 · 4 comments
Closed

[APM] Editing APM alerts via Generic Alerting UI is not possible #65399

smith opened this issue May 5, 2020 · 4 comments
Labels
enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support

Comments

@smith
Copy link
Contributor

smith commented May 5, 2020

  • Create a threshold alert for a service in APM
  • Go to Kibana > Alerts and Actions in Kibana Management
  • Click the alert name in the title
  • Click the Edit link in the upper right corner

A flyout open and then disappears and the screen goes blank.

This is in the JS console:

Uncaught TypeError: Cannot destructure property 'notifications' of '(0 , _useApmPluginContext.useApmPluginContext)(...).core' as it is undefined.

This is because we're passing in a component that's not wrapped with the needed context provider when we create the alert.

It should bring up the flyout and allow you to edit and save the alert.

We've opened #65549 with the Alerting team in order to make it so the edit action can be disabled in the Alerting UI.

The components used also use useUrlParams, which means they won't work for editing because they get data about the alert from the URL. Make it so we don't have to use this in the Alerting UI.

@smith smith added bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support labels May 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv
Copy link
Member

@smith Should this be closed or updated since this is no longer a bug but an enhancement?

@sorenlouv sorenlouv added enhancement New value added to drive a business result and removed bug Fixes for quality problems that affect the customer experience labels May 13, 2020
@smith
Copy link
Contributor Author

smith commented May 13, 2020

This should be closed.

@ebuildy
Copy link
Contributor

ebuildy commented Jun 25, 2021

At least, this should be indicated as a small info message: "This generated rule cant be edited"

We should be able to:

  • see rule content
  • remove rule

As you can see, there is no information at all:

Capture d’écran 2021-06-25 à 14 47 28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants