Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPM] await call to InstallPrebuiltComponentTemplates #65880

Closed
skh opened this issue May 8, 2020 · 2 comments · Fixed by #66541
Closed

[EPM] await call to InstallPrebuiltComponentTemplates #65880

skh opened this issue May 8, 2020 · 2 comments · Fixed by #66541
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Ingest Management:alpha1 Group issues for ingest management alpha1 Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@skh
Copy link
Contributor

skh commented May 8, 2020

During the installation of prebuilt index templates (v2), we install prebuilt component templates first, and then the templates which use these component templates. This happens here: https://github.com/elastic/kibana/blob/master/x-pack/plugins/ingest_manager/server/services/epm/elasticsearch/template/install.ts#L23-L24

We're probably missing an await here to ensure that the component templates are present when they are used. This wasn't a problem during testing but looks brittle.

Also, prebuilt templates are used by the base package, which is used for the first setup of Ingest Manager, so this has the potential of making the whole of Ingest Manager unusable.

(Thanks @neptunian for spotting it.)

@skh skh added bug Fixes for quality problems that affect the customer experience Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team Ingest Management:alpha1 Group issues for ingest management alpha1 labels May 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@skh
Copy link
Contributor Author

skh commented May 18, 2020

This actually happened to me now during testing, and it results in server crash due to an unhandled promise rejection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Ingest Management:alpha1 Group issues for ingest management alpha1 Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants