Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SavedObjectTypeRegistry.getVisibleTypes API #66818

Closed
pgayvallet opened this issue May 15, 2020 · 1 comment · Fixed by #70559
Closed

Add SavedObjectTypeRegistry.getVisibleTypes API #66818

pgayvallet opened this issue May 15, 2020 · 1 comment · Fixed by #70559
Labels
chore enhancement New value added to drive a business result Feature:New Platform Feature:Saved Objects Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@pgayvallet
Copy link
Contributor

We currently have a getAllTypes API exposed from the registry that returns all types, including the hidden ones. Even if accessing all type is necessary in some situations, the most common use case is to only access the list of visible types. This currently requires to manually filter the returned types from getAllTypes

We should add a getVisibleType API to the registry, and update the jsdoc about getAllTypes to make it clear that hidden types are also returned.
@pgayvallet pgayvallet added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform enhancement New value added to drive a business result Feature:Saved Objects labels May 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@pgayvallet pgayvallet mentioned this issue May 15, 2020
Merged
7 tasks
This was referenced Jul 2, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore enhancement New value added to drive a business result Feature:New Platform Feature:Saved Objects Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add getVisibleTypes API to SO type registry pgayvallet/kibana
2 participants
@pgayvallet @elasticmachine