-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Visualizations triggered by Discover should be handled by Lens #67415
Comments
Depends on #59845 |
Pinging @elastic/kibana-app (Team:KibanaApp) |
Going to update this issue because we have a simpler option, which is no longer blocked by the larger-scope concept of "opening a pre-filled Lens editor". The simpler option is to implement a handler for the In Lens terms, we already have a function called |
Proposal:
The downside of this is that it's building on top of the already messy initalization logic within the editor frame effect hooks. We have plans to refactor this and move the state management out of react, but it's not done yet. We could put this on hold until the state management is done, but I'm would definitely be fine with implementing it in the current code base. Open questions:
|
I have tested the |
Sounds great, thanks @stratoula - I think we have all of the building blocks in place and can start implementing this as soon as it fits in. |
@flash1293 what we will lose with not having a special link is the getHref of the uiActions meaning the right click and open in new Tab from Discover. But maybe we don't want this for Lens (?) |
@stratoula Let's implement it without an href for now (just a regular button). We can always extend later, but a URL scheme might be hard to take back |
In Discover top values there is a way to jump into a visualization that lands the users in Visuzlie editor.
For Lens GA I would like to suggest to change it to land in Lens instead of Visualize
The text was updated successfully, but these errors were encountered: