Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Fitting filling options for missing buckets #68403

Closed
flash1293 opened this issue Jun 5, 2020 · 6 comments · Fixed by #69820
Closed

[Lens] Fitting filling options for missing buckets #68403

flash1293 opened this issue Jun 5, 2020 · 6 comments · Fixed by #69820
Assignees
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

Provide settings for Lens to specify fitting/filling options for missing buckets. Elastic-charts offers a variety of settings for this.

Parent issue: #17717

Unclear:
Is this a series level setting or a chart level setting or a layer level setting? What will be in the first iteration? Everything elastic-chart exposes? A little less? All of it seems a little overwhelming

@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Jun 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 changed the title Lens Fitting filling options for missing buckets [Lens] Fitting filling options for missing buckets Jun 5, 2020
@wylieconlon
Copy link
Contributor

wylieconlon commented Jun 5, 2020

I think every layer and series should have the same fitting function. I tried out some examples to see if I could come up with a reason to use two different fitting functions, but couldn't come up with a good example.

The best reason I could think of is if you are showing two layers with different time intervals, but I'm not sure this is a great visualization.

Also, I found that when using the count metric we don't apply the fitting functions because of the shape of the data. The most reliable way to trigger fitting functions for me is to use metricbeat data on Max of process.cpu.total.pct, which is a metric that is not continuous.

I think the form should be at the chart level, and the only option that I don't think we should support is "Explicit" because it requires an extra input.

@flash1293
Copy link
Contributor Author

I think every layer and series should have the same fitting function. I tried out some examples to see if I could come up with a reason to use two different fitting functions, but couldn't come up with a good example.

Makes a lot of sense, thanks!

the only option that I don't think we should support is "Explicit" because it requires an extra input.

Sounds good to me as well. Why are you concerned about the extra input? Complexity we should avoid if it's not totally necessary?

@flash1293
Copy link
Contributor Author

Depends on #67384

@wylieconlon
Copy link
Contributor

Yes, the main reason is that it's extra complexity, but also that I don't know the use case for it. In the parent issue there were several requests for "Zero" as the most common explicit number

@flash1293
Copy link
Contributor Author

Should be disabled for bar charts. Keep the state around but don't use it if a bar chart is selected. XY chart only for now to leverage elastic-charts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants