Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest Manager] Switch from HashRouter to platform-provided BrowserRouter #70358

Closed
jen-huang opened this issue Jun 30, 2020 · 2 comments
Closed

[Ingest Manager] Switch from HashRouter to platform-provided BrowserRouter #70358

jen-huang opened this issue Jun 30, 2020 · 2 comments
Labels
Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture

Comments

@jen-huang
Copy link
Contributor

Currently the Ingest Manager app uses HashRouter for routing. We should switch over to the platform-provided BrowserRouter in order to:

  • Be consistent with other apps, especially removing current intra-app routing workarounds with Endpoint management
  • Be able to handle query params better
@jen-huang jen-huang added technical debt Improvement of the software architecture and operational architecture Team:Fleet Team label for Observability Data Collection Fleet team labels Jun 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@ph ph added the v7.12.0 label Dec 3, 2020
@jen-huang jen-huang removed the v7.12.0 label Feb 10, 2021
@jen-huang
Copy link
Contributor Author

Closing in favor of #96134.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ph @jen-huang @elasticmachine