Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test-failed]: Chrome UI Functional Tests1.test/functional/apps/dashboard/bwc_shared_urls·js.dashboard app using legacy data bwc shared urls 6.0 urls loads an unsaved dashboard #71186

Closed
liza-mae opened this issue Jul 9, 2020 · 13 comments · Fixed by #72109
Assignees
Labels
bug Fixes for quality problems that affect the customer experience failed-test A test failure on a tracked branch, potentially flaky-test regression Team:Visualizations Visualization editors, elastic-charts and infrastructure test-cloud

Comments

@liza-mae
Copy link
Contributor

liza-mae commented Jul 9, 2020

Version: 7.9.0, 8.0.0 Snapshots
Class: Chrome UI Functional Tests1.test/functional/apps/dashboard/bwc_shared_urls·js
Stack Trace:
Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="queryInput"])
Wait timed out after 10018ms
at /var/lib/jenkins/workspace/elastic+estf-cloud-kibana-tests/JOB/ossGrp3/TASK/saas_run_kibana_tests/node/linux-immutable/ci/cloud/common/build/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
at process._tickCallback (internal/process/next_tick.js:68:7)
at onFailure (test/common/services/retry/retry_for_success.ts:28:9)
at retryForSuccess (test/common/services/retry/retry_for_success.ts:68:13
Platform: cloud
Build Num: 453

@liza-mae liza-mae added Team:Visualizations Visualization editors, elastic-charts and infrastructure failed-test A test failure on a tracked branch, potentially flaky-test test-cloud :KibanaApp/fix-it-week labels Jul 9, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-test-triage (failed-test)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@liza-mae
Copy link
Contributor Author

liza-mae commented Jul 9, 2020

There are multiple failures

  • dashboard app using legacy data bwc shared urls 6_0 urls loads a saved dashboard
  • dashboard app using legacy data bwc shared urls 6_0 urls uiState in url takes precedence over saved dashboard state
  • dashboard app using current data legacy urls kibana link redirect redirects from old kibana app URL
  • dashboard app using legacy data bwc shared urls 6_0 urls loads an unsaved dashboard
  • dashboard app using legacy data bwc shared urls 6_0 urls back button works for old dashboards after state migrations
  • dashboard app using legacy data bwc shared urls 5_6 urls url with filters and query

@liza-mae
Copy link
Contributor Author

liza-mae commented Jul 9, 2020

I noticed these tests are coming back with application not found errors and wanted to make sure it is not a real issue. If someone can confirm? Thanks.

dashboard app using legacy data bwc shared urls 6_0 urls uiState in url takes precedence over saved dashboard state

@timroes
Copy link
Contributor

timroes commented Jul 9, 2020

@flash1293 this seems like it could be a potentially failure actually related to the split up of the kibana plugin?

@flash1293 flash1293 self-assigned this Jul 14, 2020
@liza-mae liza-mae added the bug Fixes for quality problems that affect the customer experience label Jul 14, 2020
@liza-mae
Copy link
Contributor Author

Since this is happening on 7.9.0 BC1 - it should be looked at before we release.

@flash1293
Copy link
Contributor

I'm checking it out this week

@flash1293
Copy link
Contributor

flash1293 commented Jul 16, 2020

OK, so this is a permission problem, we should definitely fix it for 7.9

It seems like the kibana_admin user has no permissions to access the kibana app anymore. I'm not sure how this can be, as it has "All" privileges on the default space and most of the features in there (discover, visualize, dashboard, ...) implicitly grant access to the kibana app as well. @legrego could you help here? I think for permissions we should just make kibana accessible by everyone.

https://github.com/flash1293/kibana/blob/28b70923df4411431fcc625f1fa0e8e8d321aec4/x-pack/plugins/features/server/oss_features.ts#L84

@legrego
Copy link
Member

legrego commented Jul 16, 2020

Yeah this was a regression caused by #71106. I'll have a PR up today to resolve this

@flash1293
Copy link
Contributor

Great, thanks @legrego ! And thanks to @liza-mae for the cloud tests, this would have been in 7.9.1 otherwise :)

@liza-mae
Copy link
Contributor Author

Thanks @legrego and @flash1293 for your prompt attention and fix ! :)

@legrego
Copy link
Member

legrego commented Jul 16, 2020

Great catch, Thanks @liza-mae for catching this with the cloud test!

@flash1293 is there a way for us to update this test to run using the kibana_admin user for CI, instead of waiting for cloud to discover this failure?

@flash1293
Copy link
Contributor

flash1293 commented Jul 17, 2020

@legrego That's not super easy because this specific test is part of the OSS test suite, this means in CI they run without x-pack. I don't think we can simply switch that to always run with x-pack as we would have the same problem in the other direction (no CI tests for OSS anymore). We could probably run the whole OSS test suite as kibana_admin in addition to the current setup, but that seems expensive to me - I'll leave this question to @elastic/kibana-qa .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience failed-test A test failure on a tracked branch, potentially flaky-test regression Team:Visualizations Visualization editors, elastic-charts and infrastructure test-cloud
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants