Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make custom inspector adapters registerable from the visType #71413

Closed
timroes opened this issue Jul 13, 2020 · 1 comment
Closed

Make custom inspector adapters registerable from the visType #71413

timroes opened this issue Jul 13, 2020 · 1 comment
Assignees
Labels
Feature:Inspector Inspector infrastructure and implementations impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort

Comments

@timroes
Copy link
Contributor

timroes commented Jul 13, 2020

This is an issue created from a discussion @ppisljar and I had.

Originally you could register a custom inspector adapter via the vis type, by adding a customAdapters flag to it. This has been removed over some of the refactorings. While building the Vega inspector panel we'd need this capabilities back now, since we need to register a specific adapter just for Vega. There is currently no proper other place where you could register it, that it would work with all cases, e.g. the PR currently registering it from within the expression function, which means, that it's not available before rendering, thus makes the embeddable not properly able to detect if the adapter is there. (Also it's mutating some context passed into the expression function, which we def shouldn't do.)

So this issue tracks adding back the capability of adding custom inspector adapters via the vis type. More notes from the chat:

visualize embeddable creates executor instance, it has the ability to provide inspectorAdapters to it, but it doesn't do so and just expects the default set (data, request)
so we need to add that back it seems, visType needs to list what adapters to initialize
and visualize embeddable needs to use that information to pass the initial list of adapters to executor

@timroes timroes added Feature:Inspector Inspector infrastructure and implementations Team:AppArch labels Jul 13, 2020
@timroes timroes mentioned this issue Jul 13, 2020
7 tasks
@ppisljar ppisljar added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort labels Jul 13, 2020
@alexwizp
Copy link
Contributor

Will be fixed in scope of #70941

@alexwizp alexwizp reopened this Jul 15, 2020
@alexwizp alexwizp self-assigned this Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Inspector Inspector infrastructure and implementations impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort
Projects
None yet
Development

No branches or pull requests

3 participants