Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index Patterns app doesn't unset its doc title #72668

Closed
cjcenizal opened this issue Jul 21, 2020 · 2 comments · Fixed by #79692
Closed

Index Patterns app doesn't unset its doc title #72668

cjcenizal opened this issue Jul 21, 2020 · 2 comments · Fixed by #79692
Labels
enhancement New value added to drive a business result Feature:Data Views Data Views code and UI - index patterns before 8.0

Comments

@cjcenizal
Copy link
Contributor

cjcenizal commented Jul 21, 2020 •
edited
Loading

Extracted from #69286. When the Index Patterns app unmounts, it needs to call chrome.docTitle.reset(); or else the browser tab title persists as "Index Patterns" when the user navigates away from the app. See #71045 for examples.
@cjcenizal cjcenizal added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Data Views Data Views code and UI - index patterns before 8.0 labels Jul 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@mattkime mattkime mentioned this issue Oct 2, 2020
Closed
63 tasks
@mattkime mattkime added Team:AppArch and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@mattkime mattkime linked a pull request Oct 6, 2020 that will close this issue
Index patterns management app - unset doc title #79692
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New value added to drive a business result Feature:Data Views Data Views code and UI - index patterns before 8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Index patterns management app - unset doc title mattkime/kibana
3 participants
@mattkime @cjcenizal @elasticmachine