Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load date fields through 'fields' instead of 'docvalue_fields'. #75813

Closed
jtibshirani opened this issue Aug 24, 2020 · 6 comments · Fixed by #82383
Closed

Load date fields through 'fields' instead of 'docvalue_fields'. #75813

jtibshirani opened this issue Aug 24, 2020 · 6 comments · Fixed by #82383
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Discover Discover Application Feature:Search Querying infrastructure in Kibana

Comments

@jtibshirani
Copy link

jtibshirani commented Aug 24, 2020

Currently the Discover search loads the document _source, and also loads date fields using docvalue_fields in order to apply the right formatting. Doc values are column-oriented and are more expensive to retrieve, so Elasticsearch places a limit on the number of fields that can be retrieved (index.max_docvalue_fields_search). If a user has more date fields than this limit, the Discover search can fail.

Elasticsearch merged a new fields option that loads fields from _source, and supports date formatting. Discover could switch to loading dates through fields instead of docvalue_fields to prevent hitting the limit.

This would resolve #22897. Also relates to #69049.

@jtibshirani jtibshirani added bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 24, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon wylieconlon removed the bug Fixes for quality problems that affect the customer experience label Aug 24, 2020
@nreese nreese added the [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation label Aug 24, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese
Copy link
Contributor

nreese commented Aug 24, 2020

Adding geo tag since maps also loads date fields via doc_values.

@kertal
Copy link
Member

kertal commented Sep 17, 2020

For this change SearchSource has to support fields, so adding AppArch

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lukeelmers
Copy link
Member

Somehow I had missed this issue until now -- I'm planning to address this as a part of the work for #77241.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Discover Discover Application Feature:Search Querying infrastructure in Kibana
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants