Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data.indexPatterns] Replace StubIndexPattern with a more detailed jest mock #78519

Closed
lukeelmers opened this issue Sep 24, 2020 · 1 comment · Fixed by #108555
Closed

[data.indexPatterns] Replace StubIndexPattern with a more detailed jest mock #78519

lukeelmers opened this issue Sep 24, 2020 · 1 comment · Fixed by #108555
Assignees
@Dosant
Labels
chore Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort

Comments

@lukeelmers
Copy link
Member

In #78518 we relocated the StubIndexPattern from the legacy test_utils to the data plugin.

However, this is still pretty old code (using sinon), and ideally we should get rid of it altogether and replace it with a more detailed jest mock supplied as a part of the mock plugin contracts exported from src/plugins/data/public/mocks
@lukeelmers lukeelmers added chore Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:AppArch labels Sep 24, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lukeelmers lukeelmers mentioned this issue Sep 24, 2020
Merged
@mattkime mattkime self-assigned this Sep 25, 2020
@mattkime mattkime mentioned this issue Sep 25, 2020
Closed
63 tasks
@mattkime mattkime mentioned this issue Jun 17, 2021
Merged
4 tasks
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 21, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Jul 6, 2021
@Dosant Dosant assigned Dosant and unassigned mattkime Aug 12, 2021
@Dosant Dosant mentioned this issue Aug 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dosant Dosant

Labels
chore Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[IndexPatterns] Clean up StubIndexPattern Dosant/kibana
4 participants
@mattkime @lukeelmers @Dosant @elasticmachine