Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test-failed]: Chrome UI Functional Tests1.test/functional/apps/timelion/_expression_typeahead·js - timelion app expression typeahead "before all" hook for "should display function suggestions filtered by function name" #80247

Closed
liza-mae opened this issue Oct 13, 2020 · 14 comments
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Timelion Timelion app and visualization Team:Visualizations Visualization editors, elastic-charts and infrastructure test-cloud

Comments

@liza-mae
Copy link
Contributor

Version: 7.10.0
Class: Chrome UI Functional Tests1.test/functional/apps/timelion/_expression_typeahead·js
Stack Trace:

Error: retry.tryForTime timeout: Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="kibanaChrome"])
Wait timed out after 61226ms
   at /var/lib/jenkins/workspace/elastic+estf-cloud-kibana-tests/JOB/ossGrp1/TASK/saas_run_kibana_tests/node/linux-immutable/ci/cloud/common/build/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
   at process._tickCallback (internal/process/next_tick.js:68:7)
   at onFailure (test/common/services/retry/retry_for_success.ts:28:9)
   at retryForSuccess (test/common/services/retry/retry_for_success.ts:68:13)
   at onFailure (test/common/services/retry/retry_for_success.ts:28:9)
   at retryForSuccess (test/common/services/retry/retry_for_success.ts:68:13)

Other test failures:

Test Report: https://internal-ci.elastic.co/view/Stack%20Tests/job/elastic+estf-cloud-kibana-tests/845/testReport/

@liza-mae liza-mae added failed-test A test failure on a tracked branch, potentially flaky-test test-cloud labels Oct 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-test-triage (failed-test)

@liza-mae liza-mae added Team:Visualizations Visualization editors, elastic-charts and infrastructure :KibanaApp/fix-it-week labels Oct 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula
Copy link
Contributor

As far as I can see when this test fails, many others fail with the same error. So I don't think it is related to the specific test.
@dmlemeshko any ideas here?

@dmlemeshko
Copy link
Member

dmlemeshko commented Oct 20, 2020

The failure is related to this part of code:

  class TimelionPage {
    public async initTests() {
      await kibanaServer.uiSettings.replace({
        defaultIndex: 'logstash-*',
      });

      log.debug('load kibana index');
      await esArchiver.load('timelion');

      await PageObjects.common.navigateToApp('timelion');
    }

And based on error my guess is that PageObjects.common.navigateToApp('timelion') did not properly load the page, could be a continuous spinner or just blank page. We saw this problem with security functional tests in Kibana CI, I'm not sure if the problem was identified and fixed. To conclude, it has nothing to do with particular test (Timelion functionality), but can be related to test order execution or Kibana low performance during execution.

@dmlemeshko
Copy link
Member

@liza-mae could you include screenshots to test failures? it should help understanding the place and reason.

@stratoula
Copy link
Contributor

Thank you @dmlemeshko, from what I can see from Jenkins we get this
timelion app expression typeahead before all hook

And in the same build another test fails with:
management  index pattern filter before all hook

@dmlemeshko
Copy link
Member

Ok, then it means we need to update suite to add user proper permissions. @rashmivkulkarni could help here. Since it works fine on Kibana CI, changing tests order could be a reason.

@LeeDr
Copy link

LeeDr commented Oct 20, 2020

Looking at the Jenkins job mentioned in the description, there's a ton of 403 errors being logged and other tests failing before it gets to this one. The issue could be related to role changes. The OSS tests by default are run with the roles defined here; https://github.com/elastic/kibana/blob/7.10/test/functional/config.js#L292

defaultRoles: ['test_logstash_reader', 'kibana_admin'],

It could be that we need to change that kibana_admin role to use Kibana feature and space privileges.

@rashmivkulkarni is starting a local test.

@rashmivkulkarni
Copy link
Contributor

prior test failed to save a query- here is the screenshot:
Screen Shot 2020-10-20 at 10 37 24 AM

@rashmivkulkarni
Copy link
Contributor

local test run againsta a 7.10 cloud instance - running exclusive test - expression_typeahead.js with the tags --include-tag=ciGroup1 --exclude-tag=skipCloud - passes .

Screen Shot 2020-10-20 at 10 44 50 AM

when the entire ciGroup1 was run on 7.10 instance of cloud.
Screen Shot 2020-10-20 at 10 57 46 AM

@LeeDr
Copy link

LeeDr commented Oct 20, 2020

Still not sure what the problem is on this test. The index file for _expression_typeahead loads logstash_functional test data and sets the default index pattern to logstash-*. And the test calls timelion.initTests() which only loads a Kibana index, so the default roles of
defaultRoles: ['test_logstash_reader', 'kibana_admin'], should be fine. It really seems like something broke before this test and we need to work our way down the list in the order they're failing.

@stratoula
Copy link
Contributor

stratoula commented Oct 21, 2020

Thank you @LeeDr and @rashmivkulkarni for looking into this. 🙂 It is a very interesting case

@timroes timroes added the Feature:Timelion Timelion app and visualization label Nov 4, 2020
@LeeDr
Copy link

LeeDr commented Nov 10, 2020

@rashmi worked on another test related to permissions and this could be a similar case. The test created a user with dashboard read or dashboard all privs and yet when it opened a saved dashboard it would fail because it couldn't update a saved object. The saved object it was trying to update was the index pattern. Apparently index patterns have a flag (or lack of a flag) and they need to be updated on first use, which requires different privs.
And we think that update also fails occasionally #81457 (comment)

I also found a test which was deleting all indices including the security index! This of course breaks all tests that come after it. I have a PR to fix that test here; #82736

@liza-mae
Copy link
Contributor Author

liza-mae commented Dec 4, 2020

Fixed

@liza-mae liza-mae closed this as completed Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Timelion Timelion app and visualization Team:Visualizations Visualization editors, elastic-charts and infrastructure test-cloud
Projects
None yet
Development

No branches or pull requests

7 participants