Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics UI] Enhanced host details - Logs #80308

Closed
sorantis opened this issue Oct 13, 2020 · 9 comments · Fixed by #83433
Closed

[Metrics UI] Enhanced host details - Logs #80308

sorantis opened this issue Oct 13, 2020 · 9 comments · Fixed by #83433
Assignees
Labels
enhancement New value added to drive a business result Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@sorantis
Copy link

Add Logs tab to Enhanced Host Details

Screen Shot 2020-10-13 at 11 38 37

Details

  • Use the LogStream component to show logs from the host.
  • the Open in Logs link opens the Logs app with prefilled filter : host.name
@sorantis sorantis added enhancement New value added to drive a business result Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Oct 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@sgrodzicki
Copy link

@afgomez your help from the Logs UI perspective would be very much appreciated.

@afgomez
Copy link
Contributor

afgomez commented Nov 4, 2020

👋! For the log stream component itself, you can find the docs in https://github.com/elastic/kibana/blob/master/x-pack/plugins/infra/public/components/log_stream/README.md

The component doesn't include a searchbox, so you will have to implement it yourselves. The easiest way would be to pass the KQL expression on the searchbox to the component through its query prop.

For the "Open in logs" button, the infra plugin has a useLinkProps hook that can be used for that.

Let me know if you have any specific questions about the component!

@phillipb phillipb self-assigned this Nov 13, 2020
@phillipb
Copy link
Contributor

@sorantis is the "Search for log entries" textbox supposed to redirect you to logs UI? From what I can tell, there is no search ability in the LogStream component. Is that right @afgomez?

If it is only meant to be a redirect, I think we should remove it. The "Open in Logs" button already achieves that functionality

@weltenwort
Copy link
Member

As @afgomez wrote, you can pass arbitrary queries to the component:

The component doesn't include a searchbox, so you will have to implement it yourselves. The easiest way would be to pass the KQL expression on the searchbox to the component through its query prop.

@sorantis
Copy link
Author

The search box is supposed to be used to filter logs in LogStream.

@phillipb
Copy link
Contributor

Thanks, @weltenwort I missed that. @sorantis what should the timeframe be for the logs? The LogStream component requires you to specify a fixed start and end time for the stream.

@sorantis
Copy link
Author

I think the time range should be aligned with the time ranged used across all Kibana apps.

A couple of questions regarding the component:

  • Can LogStream automatically preload entries while scrolling?
  • Does LogStream support Live tail?

@afgomez
Copy link
Contributor

afgomez commented Nov 16, 2020

👋 @sorantis

  • Can LogStream automatically preload entries while scrolling?

Yes. It was merged last week on master

  • Does LogStream support Live tail?

No. We also don't plan to implement it in the short term. If this is important and the containing page has a SuperDatePicker with auto-refresh it can be tied to it. (once #83302 is merged)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants