-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debugging 500 errors on Cloud #80857
Comments
Conceptually, I think it's fine for us to include the response body from Elasticsearch 503s in Kibana's response bodies. We do want to ensure that Kibana's responses do not contain sensitive information, like file-paths or username/passwords, but if Elasticsearch error's response includes a body, and Elasticsearch has ensured that the response bodies don't contain sensitive information, those are transitively safe to expose to end-users. It does feel like we should make it clear that it's an Elasticsearch 503 as opposed to a Kibana 503. Just proxying the ES response through potentially loses this differentiation. |
|
@pgayvallet I think this is generally alright. I do think it's sometimes awkward that we're propagating ES errors to the end-users because the specific calls that Kibana is making to Elasticsearch should generally be seen as an "implementation detail" of Kibana. For example, it'd be weird to return an error that refers to the Ideally, more consumers of ES would "wrap" the calls and throw informative, yet non-ES specific, errors when they got an unexpected status-code, but 🤷 |
I think we can close this, given that:
|
On today's Bugpool was raised the problem that it's hard for support and customers to diagnose 500 errors returned by Kibana Server.
During the migration to the Kibana platform, we deliberately decided not to provide error details on uncaught exceptions to prevent error details leaking, but log them instead. There are at least two problems with the current approach:
401
errors preserve 401 errors from legacy es client #71234@kobelb @elastic/kibana-platform
The text was updated successfully, but these errors were encountered: