Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet][GS] Add Fleet deep links to navigational search #86171

Closed
joshdover opened this issue Dec 16, 2020 · 8 comments · Fixed by #102227
Closed

[Fleet][GS] Add Fleet deep links to navigational search #86171

joshdover opened this issue Dec 16, 2020 · 8 comments · Fixed by #102227
Assignees
Labels
enhancement New value added to drive a business result Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@joshdover
Copy link
Contributor

joshdover commented Dec 16, 2020

Currently blocked by #96134

Meta issue: #72680

In #83380 we added support for applications to include a searchDeepLinks property on their core.application.register call which feeds into the navigational search feature.

Fleet should add this property to add deep links for their key locations to search. In most cases, this should be adding an array with the name of the location and a URL path to the route in your app. See the documentation for this API for more info. Some things to consider:

  • The title for each link should be localized
  • The path for each link should be relative to your application's appRoute. Base path does not need to be included.
  • If there are locations that are only conditionally available (for example, due to licensing or feature controls), you can utilize the appUpdater$ API. See the example in the Stack Management app.

New links to add

Fleet

  • Overview (same entry point as Fleet app)
  • Integrations
  • Including all available integrations
  • Configurations
  • Fleet
  • Datasets
  • Add agent
@joshdover joshdover added enhancement New value added to drive a business result Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team labels Dec 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Feature:Fleet)

@jfsiii
Copy link
Contributor

jfsiii commented Dec 17, 2020

I think we can add/export a new data structure in
https://github.com/elastic/kibana/blob/d18fca3b8265bc2276800aec9b322f378abfeadb/x-pack/plugins/fleet/public/applications/fleet/constants/page_paths.ts that gets the path value from the existing variables like

@joshdover
Copy link
Contributor Author

@jfsiii @jen-huang Is this something that will make 7.12? I imagine it's not a whole lot of work based off the suggestion above.

@jfsiii
Copy link
Contributor

jfsiii commented Jan 26, 2021

@joshdover I think you're right that it's not a lot of work, but cc @ph because I don't believe we have assigned this to a release.

@jen-huang jen-huang changed the title [GS] Add Fleet deep links to navigational search [Fleet][GS] Add Fleet deep links to navigational search Apr 27, 2021
@jen-huang
Copy link
Contributor

@jloleysens I found this old issue that would be closed by your PR #102227 :) The AC here talks about the subpages too, but now that Integrations is separated out, I'm comfortable with just Integrations + Fleet present in the search results.

@dikshachauhan-qasource
Copy link

Hi @jloleysens

While performing testing on #102227 feature merges, we have come up with following queries:

  • Could you please confirm how a package is defined. Like Apache is accepted as package while Windows and other few integrations are not at global search bar with type:package filter.
  • What are the expected inputs to hit search as a package. Aren't all integrations are eligible to be searched under it.

For now we have reported issue: #104411

Thanks
QAS

@jloleysens
Copy link
Contributor

I'll respond on the open issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants