Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GS] Add Dev Tools deep links to navigational search #86172

Closed
joshdover opened this issue Dec 16, 2020 · 6 comments
Closed

[GS] Add Dev Tools deep links to navigational search #86172

joshdover opened this issue Dec 16, 2020 · 6 comments
Labels
enhancement New value added to drive a business result Feature:Dev Tools Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@joshdover
Copy link
Contributor

joshdover commented Dec 16, 2020

Meta issue: #72680

In #83380 we added support for applications to include a searchDeepLinks property on their core.application.register call which feeds into the navigational search feature.

Dev Tools should add this property to add deep links for their key locations to search. In most cases, this should be adding an array with the name of the location and a URL path to the route in your app. See the documentation for this API for more info. Some things to consider:

  • The title for each link should be localized
  • The path for each link should be relative to your application's appRoute. Base path does not need to be included.
  • If there are locations that are only conditionally available (for example, due to licensing or feature controls), you can utilize the appUpdater$ API. See the example in the Stack Management app.
    • This will probably apply to dev tools so that the links to the tools registered from X-Pack are only shown in search when they are present/enabled.

New links to add

Dev tools

  • Console (same entry point as Dev Tools app)
  • Search profiler
  • Grok Debugger
  • Painless Lab
@joshdover joshdover added enhancement New value added to drive a business result Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Dec 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@joshdover
Copy link
Contributor Author

@cjcenizal Any updates on when this might be possible?

@cjcenizal
Copy link
Contributor

cjcenizal commented Jan 26, 2021

@joshdover In theory it's possible we might be able to squeeze this into 7.13, but we have a number of high priority projects on our roadmap that already occupy our full team capacity so it seems unlikely. The earliest empty slot on our roadmap is in 7.15.

@joshdover
Copy link
Contributor Author

@cjcenizal Thanks for the update! I really hope this wouldn't take more than a couple of days and I'm happy to help however I can.

@joshdover
Copy link
Contributor Author

This has been mostly solved by #96135 except for the Painless Lab case. This one needs to be worked a bit separately because it doesn't currently provide a plain string representation of the app's title to the dev_tools plugin.

@alisonelizabeth
Copy link
Contributor

Closing this issue as most of the work has been completed. We can open up a separate issue for Painless Lab, if needed.

@alisonelizabeth alisonelizabeth closed this as not planned Won't fix, can't repro, duplicate, stale Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Dev Tools Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

4 participants