You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently disable angular debug info when we are in "production" mode, but after #9151 I think we should disable it in development mode too. Ideally there would be an easy way to turn it on without having to modify the source.
The text was updated successfully, but these errors were encountered:
Let's not jump the gun on this one just yet. Yes, we did run into an issue where an existing dependency relied with that change, but this is something our automated testing should really be catching. Our current dependencies work fine without the debug info, and since new features should have appropriate tests, any new feature that pulls in a dependency that breaks on this should fail in CI.
And any dependency that relies on this debugging code should be pretty heavily scrutinized at that point anyway.
We talked about this as a team and decided that we aren't totally sold on the value of removing the debugging info. We use it a lot more than it bites us in the butt.
That said, we should clearly define the bad usage patterns and ensure that everyone is aware of what is and isn't allowed (just like people know not to commit console.log()s and debuggers).
For now we will play this out and see if it gets any worse
We currently disable angular debug info when we are in "production" mode, but after #9151 I think we should disable it in development mode too. Ideally there would be an easy way to turn it on without having to modify the source.
The text was updated successfully, but these errors were encountered: