Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require opting-into angular debug info #9154

Closed
spalger opened this issue Nov 19, 2016 · 2 comments
Closed

Require opting-into angular debug info #9154

spalger opened this issue Nov 19, 2016 · 2 comments

Comments

@spalger
Copy link
Contributor

spalger commented Nov 19, 2016

We currently disable angular debug info when we are in "production" mode, but after #9151 I think we should disable it in development mode too. Ideally there would be an easy way to turn it on without having to modify the source.

@epixa
Copy link
Contributor

epixa commented Dec 12, 2016

Let's not jump the gun on this one just yet. Yes, we did run into an issue where an existing dependency relied with that change, but this is something our automated testing should really be catching. Our current dependencies work fine without the debug info, and since new features should have appropriate tests, any new feature that pulls in a dependency that breaks on this should fail in CI.

And any dependency that relies on this debugging code should be pretty heavily scrutinized at that point anyway.

@spalger spalger removed the discuss label Dec 12, 2016
@spalger
Copy link
Contributor Author

spalger commented Dec 12, 2016

We talked about this as a team and decided that we aren't totally sold on the value of removing the debugging info. We use it a lot more than it bites us in the butt.

That said, we should clearly define the bad usage patterns and ensure that everyone is aware of what is and isn't allowed (just like people know not to commit console.log()s and debuggers).

For now we will play this out and see if it gets any worse

@spalger spalger closed this as completed Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants