Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] split validation of expected repo state into separate tasks #93320

Closed
spalger opened this issue Mar 2, 2021 · 1 comment · Fixed by #93329
Closed

[ci] split validation of expected repo state into separate tasks #93320

spalger opened this issue Mar 2, 2021 · 1 comment · Fixed by #93329
Assignees
Labels
Feature:CI Continuous integration Team:Operations Team label for Operations Team

Comments

@spalger
Copy link
Contributor

spalger commented Mar 2, 2021

When we first started bootstrapping in CI we added validation after bootstrap that there weren't any changes to the repo (specifically concerned about the yarn.lock file) after running yarn kbn bootstrap. This method of verification has been extended to a number of other tasks which run a build script and validate that there aren't any additional changes after running that script. We should really break those out into separate tasks so that they are identified as the actual failed task in the PR report, they don't trigger additional bootstraps (because retries) and they can be reported as Github Status Checks if desired.

@spalger spalger added Team:Operations Team label for Operations Team Feature:CI Continuous integration labels Mar 2, 2021
@spalger spalger self-assigned this Mar 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:CI Continuous integration Team:Operations Team label for Operations Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants