From ebd3926f934dfaecd0b4637a8b246cff7ce9a84b Mon Sep 17 00:00:00 2001 From: ppisljar Date: Fri, 3 Feb 2017 10:51:12 +0100 Subject: [PATCH 1/3] allow visualizations to hide sidebar editor --- .../kibana/public/visualize/editor/editor.html | 10 +++++++--- .../kibana/public/visualize/editor/styles/_editor.less | 7 +++++++ src/ui/public/vis/vis_type.js | 1 + 3 files changed, 15 insertions(+), 3 deletions(-) diff --git a/src/core_plugins/kibana/public/visualize/editor/editor.html b/src/core_plugins/kibana/public/visualize/editor/editor.html index e5535094f24cc..cc64b48cb63ff 100644 --- a/src/core_plugins/kibana/public/visualize/editor/editor.html +++ b/src/core_plugins/kibana/public/visualize/editor/editor.html @@ -73,11 +73,14 @@
-
- + + +
+
-
+
+
diff --git a/src/core_plugins/kibana/public/visualize/editor/styles/_editor.less b/src/core_plugins/kibana/public/visualize/editor/styles/_editor.less index a5b4da6db1abf..cc2aa2211a8c5 100644 --- a/src/core_plugins/kibana/public/visualize/editor/styles/_editor.less +++ b/src/core_plugins/kibana/public/visualize/editor/styles/_editor.less @@ -128,6 +128,13 @@ } } + .vis-editor-full-options { + display: flex; + flex-direction: column; + flex: 1 0 auto; + padding: 0px; + } + .vis-editor-agg { .flex-parent(); diff --git a/src/ui/public/vis/vis_type.js b/src/ui/public/vis/vis_type.js index 39c3de6ecaf79..011e92b4ed06d 100644 --- a/src/ui/public/vis/vis_type.js +++ b/src/ui/public/vis/vis_type.js @@ -15,6 +15,7 @@ export default function VisTypeFactory(Private) { this.schemas = opts.schemas || new VisTypeSchemas(); this.params = opts.params || {}; this.requiresSearch = opts.requiresSearch == null ? true : opts.requiresSearch; // Default to true unless otherwise specified + this.fullEditor = opts.fullEditor == null ? false : opts.fullEditor; this.implementsRenderComplete = opts.implementsRenderComplete || false; } From 10d6cff9c988389dd6007c989567bcf86385448a Mon Sep 17 00:00:00 2001 From: ppisljar Date: Fri, 3 Feb 2017 15:37:54 +0100 Subject: [PATCH 2/3] fixing styles --- .../kibana/public/visualize/editor/styles/_editor.less | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core_plugins/kibana/public/visualize/editor/styles/_editor.less b/src/core_plugins/kibana/public/visualize/editor/styles/_editor.less index cc2aa2211a8c5..22a9ecb2771b1 100644 --- a/src/core_plugins/kibana/public/visualize/editor/styles/_editor.less +++ b/src/core_plugins/kibana/public/visualize/editor/styles/_editor.less @@ -128,7 +128,7 @@ } } - .vis-editor-full-options { + .vis-editor-full-options .visualization-options { display: flex; flex-direction: column; flex: 1 0 auto; From 7a6aa89699ae9d008ea0fe864538d95e24b94631 Mon Sep 17 00:00:00 2001 From: ppisljar Date: Fri, 3 Feb 2017 16:00:45 +0100 Subject: [PATCH 3/3] fixing broken html --- src/core_plugins/kibana/public/visualize/editor/editor.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core_plugins/kibana/public/visualize/editor/editor.html b/src/core_plugins/kibana/public/visualize/editor/editor.html index cc64b48cb63ff..d675297daffa6 100644 --- a/src/core_plugins/kibana/public/visualize/editor/editor.html +++ b/src/core_plugins/kibana/public/visualize/editor/editor.html @@ -74,7 +74,7 @@
+ class="vis-editor-full-options">