Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controls visualization - format options list #16804

Merged
merged 1 commit into from
Feb 22, 2018
Merged

Controls visualization - format options list #16804

merged 1 commit into from
Feb 22, 2018

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Feb 19, 2018

fixes #16701

Use field formatter to format option list label.

screen shot 2018-02-18 at 9 54 10 pm

screen shot 2018-02-18 at 9 54 18 pm

@nreese nreese requested a review from stacey-gammon February 19, 2018 04:56
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

stacey-gammon
stacey-gammon approved these changes Feb 22, 2018
View reviewed changes
Copy link
Contributor

@stacey-gammon stacey-gammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We may want to think about what to do with the range controls eventually, but that could be tackled separately since there isn't an obvious solution and I imagine not as prominent as this issue. e.g. what if I want my range to show my field as percentage - though looks like right now we can't have non whole steps so that doesn't work anyway. The problem comes in with parsing the input of the range sides (we probably don't want to be parsing 19kb into a raw value, etc).

@nreese nreese merged commit 5cacfb9 into elastic:master Feb 22, 2018
@nreese nreese mentioned this pull request Feb 22, 2018
Closed
nreese added a commit to nreese/kibana that referenced this pull request Feb 22, 2018
@nreese
use field formattor to format list options (elastic#16804)
2179a77
nreese added a commit to nreese/kibana that referenced this pull request Feb 23, 2018
@nreese
use field formattor to format list options (elastic#16804)
60028b3
@nreese nreese mentioned this pull request Feb 23, 2018
Merged
nreese added a commit that referenced this pull request Feb 23, 2018
@nreese
use field formattor to format list options (#16804) (#16896)
76722b0
@nreese nreese mentioned this pull request Mar 8, 2018
Closed
@nreese nreese mentioned this pull request May 8, 2018
Closed
@fatmali
Copy link

fatmali commented Jul 30, 2018

@nreese thanks for this feature! We are embedding kibana dashboards into our app and wanted to know the following:

  1. Is this feature available in 6.3.2?
  2. If so, could you give us a guide that will enable us to use this feature to allow our users to manipulate a time field such as the @timestamp pic above?

Looking forward to your reply!

@nreese
Copy link
Contributor Author

nreese commented Jul 30, 2018

This feature is in 6.3.

You will have to add a field formatter for the field used by the control. Field formatters are managed under Index Patterns - https://www.elastic.co/guide/en/kibana/current/managing-fields.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stacey-gammon stacey-gammon stacey-gammon approved these changes

Assignees
No one assigned
Labels
Feature:Input Control Input controls visualization release_note:fix v6.3.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option list in Controls visualization does not format dates in human readable format
4 participants
@nreese @elasticmachine @fatmali @stacey-gammon