From 814199855554cd9f2aa8bb8a5606d36d24de3e89 Mon Sep 17 00:00:00 2001 From: joe fleming Date: Mon, 12 Nov 2018 13:00:35 -0700 Subject: [PATCH 1/2] fix: switch to new CustomEvent new Event is not supported in IE11 --- .../element_share_container/element_share_container.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/plugins/canvas/public/components/element_share_container/element_share_container.js b/x-pack/plugins/canvas/public/components/element_share_container/element_share_container.js index 6cecf7bc425fd..e2afd9e2e0459 100644 --- a/x-pack/plugins/canvas/public/components/element_share_container/element_share_container.js +++ b/x-pack/plugins/canvas/public/components/element_share_container/element_share_container.js @@ -38,7 +38,7 @@ export class ElementShareContainer extends React.PureComponent { onComplete(() => { clearTimeout(this.timeout); if (!this.sharedItemRef) return; // without this, crazy fast forward/backward paging leads to an error - const ev = new Event('renderComplete'); + const ev = new CustomEvent('renderComplete'); this.sharedItemRef.dispatchEvent(ev); // if the element is finished before reporting is listening for then From e5100682c20106cc74c2474609d6b910255b4867 Mon Sep 17 00:00:00 2001 From: joe fleming Date: Mon, 12 Nov 2018 13:13:06 -0700 Subject: [PATCH 2/2] fix: skip element.scrollTo when not available that method doesn't exist on elements in IE11 --- .../canvas/public/components/page_manager/page_manager.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/x-pack/plugins/canvas/public/components/page_manager/page_manager.js b/x-pack/plugins/canvas/public/components/page_manager/page_manager.js index 66c2196c0f900..d15fa26cce0cb 100644 --- a/x-pack/plugins/canvas/public/components/page_manager/page_manager.js +++ b/x-pack/plugins/canvas/public/components/page_manager/page_manager.js @@ -53,6 +53,10 @@ export class PageManager extends React.PureComponent { scrollToActivePage = () => { if (this.activePageRef && this.pageListRef) { + // not all target browsers support element.scrollTo + // TODO: replace this with something more cross-browser, maybe scrollIntoView + if (!this.pageListRef.scrollTo) return; + const pageOffset = this.activePageRef.offsetLeft; const { left: pageLeft,