-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TLS options for integration package #2200
Comments
I think for now we should solve it at the package level. It means every package needs to repeat its config. What should happen on the creation side, for example in the integrations repo, is that it is defined in a reusable way. But the final package does contain the full configs. @exekias @urso Thoughts? |
@ruflin This works for most of the fields like verification_mode, but we would probably still need some logic in the EPM to propose a browse files for the Certificate/Certificate Authorities (Can be multiple) and Private key. |
Note that I believe that CA,Certificate and Private keys will just become blob of bytes. |
TLS settings are more or less standardized between stack products. For package authors it would be nice to mark setting as "SSL" and have kibana provide a common wizard. Integrations would then provide the SSL settings as an object which we can just put in place. The value for the template could be a JSON object for example. |
@urso Yes, I think that will work... How many times we had typos from a user with TLS options, I presume it will be the same for integration author ;) |
++ on having current files as something we could pass inline (blob of bytes). I guess that would improve the story when using fleet? |
I'm not a big fan of introducing artifacts that will translate the package from a intermediate construct in the integrations repo into a final state. We should aim at having (almost) the same format in integrations and the registry. For now I think it should be ok if we just copy the same settings until we have a good solution in Kibana? |
Yes, the trust is already established between elastic-agent <-> fleet, and adding them as part of the configuration would just simplify things. Actually the "blob" feature would be part of libbeat and I think it could be useful today. beats issue: elastic/beats#19504 |
@exekias The problem are TLS options are already a reusable concept in Beats, define struct once and reuse everywhere, there is a lot of options that give more chance to get it wrong.
|
I'm not sure if having these predefined config blocks in Kibana is the way to go. Lets assume we have a breaking change on these config options from 7.x to 8.x. 7.x agents will be able to ship data to 8.0 and they will also receive configs. This will mean, 8.x Kibana will need to contain the configs for 7.x and 8.0 instead of just taking it from the package. |
I thought that having the agent at least in the version of the stack was a requirement? |
@exekias There is an exception for the latest minor that must work with the first minor of the next master. In the past, 6.8 with 7.0. Otherwise there is no upgrade path. |
Understood, I guess that's something we could take into account |
Yes, it could also be that at some stage we reintroduce some reusable components in the registry to make things easier for all contributors. Lets start with duplicating content and iterate from there. |
To move forward here, I suggest for now we make it part of each package and follow up on finding a more generic solution when we get to it. |
@ruflin Agree, initially they could reference a local file. (CA or key). |
@akshay-saraswat @ruflin Shouldn't it be part of the Integrations repository? |
Yes, you are right it should be part of integrations. This has nothing to do with the package registry. I'll move it to the integrations repo tomorrow if there are no objections raised until then. |
Pinging @elastic/integrations (Team:Integrations) |
Hi! We just realized that we haven't looked into this issue in a while. We're sorry! We're labeling this issue as |
Design issue: elastic/kibana#72718
A lot of inputs in Metricbeat and Filebeat support TLS options, we should allow a developer to enable TLS options for specific inputs so we can create a custom UI on top of it.
The text was updated successfully, but these errors were encountered: