Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix backwards compatibility to 1.14 #989

Merged
merged 3 commits into from
Dec 17, 2024
Merged

fix: fix backwards compatibility to 1.14 #989

merged 3 commits into from
Dec 17, 2024

Conversation

emilioalvap
Copy link
Contributor

  • Fix backwards compatibility to 1.14

@emilioalvap emilioalvap changed the title Fix backwards compatibility to 1.14 fix: fix backwards compatibility to 1.14 Dec 16, 2024
vigneshshanmugam
vigneshshanmugam reviewed Dec 16, 2024
View reviewed changes
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but instead of alias, I would very much in favor of asking users to not rely on these methods or callout saying use it with caution.

src/core/runner.ts Outdated Show resolved Hide resolved
@emilioalvap emilioalvap merged commit 8a73648 into main Dec 17, 2024
8 checks passed
@vigneshshanmugam vigneshshanmugam deleted the synthetics-alias-globals branch December 17, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

@shahzad31 shahzad31 Awaiting requested review from shahzad31

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilioalvap @vigneshshanmugam