Skip to content
This repository has been archived by the owner on May 24, 2023. It is now read-only.

MSI package doesn't upgrade log4j2.properties file #351

Closed
n0othing opened this issue Jan 7, 2020 · 3 comments
Closed

MSI package doesn't upgrade log4j2.properties file #351

n0othing opened this issue Jan 7, 2020 · 3 comments

Comments

@n0othing
Copy link
Member

n0othing commented Jan 7, 2020

Elasticsearch version (bin/elasticsearch --version): 7.5.1

Plugins installed: []

JVM version (java -version): n/a

OS version (uname -a if on a Unix-like system): Windows 10

Description of the problem including expected versus actual behavior:

I tried upgrading a 7.3.2 msi install to 7.5.1 and discovered the log4j2.properties file wasn't upgraded.

  • There were no custom edits to the log42.properties prior to upgrading.
  • The upgrade was performed by simply double clicking the newer version's installer (no uninstall was performed).

7.3.2 config directory

fresh_7 3 2_install

7.5.1 config directory (note the modification date)

upgrade_7 5 1_install

I think newer config files should be copied to the directory while preserving the originals (just incase there are some customizations). This is similar to how the RPM/DEB packages do it.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Packaging)

@rjernst rjernst transferred this issue from elastic/elasticsearch Jan 7, 2020
@rjernst
Copy link
Member

rjernst commented Jan 7, 2020

We have a separate repo for the MSI packages. I'm moving this issue there.

@ghost
Copy link

ghost commented Apr 29, 2020

I made a note of this issue.

@ghost ghost closed this as completed Apr 29, 2020
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants