Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Height 100vh is too tall on iOS Safari #27

Open
ArianeNubee opened this issue Jul 2, 2019 · 2 comments
Open

Height 100vh is too tall on iOS Safari #27

ArianeNubee opened this issue Jul 2, 2019 · 2 comments

Comments

@ArianeNubee
Copy link

On iOS Safari, if the two navigation bars are shown, 100vh is actually taller than the screen area available. So if you make a scrollable popup, it won't be possible to scroll down far enough to see all of the content.

In my site, just setting .basicLightbox's height to 100% instead seems to fix it.

@electerious
Copy link
Owner

electerious commented Jul 3, 2019

There was a reason why I've used 100vh, but I can't remember why :-/ 100% seems to work fine. I will do some further tests to see if there're problems. Thanks for the tip!

@milanidavide
Copy link

I ran into the same issue, you could just do:

.basicLightbox {
  position: fixed;
  top: 0;
  right: 0;
  bottom: 0;
  left: 0;
  ...
}

without specifying width and height

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants