feat(mac): option to set minimum macOS version the app is supported on

Close #2472
electron-userland · Jan 16, 2018 · 14fbed1 · 14fbed1
1 parent efc1923
commit 14fbed1
Show file tree

Hide file tree

Showing 7 changed files with 203 additions and 162 deletions.
diff --git a/package.json b/package.json
@@ -31,7 +31,7 @@
     "7zip-bin": "^2.3.4",
     "archiver": "^2.1.1",
     "async-exit-hook": "^2.0.1",
-    "aws-sdk": "^2.181.0",
+    "aws-sdk": "^2.182.0",
     "bluebird-lst": "^1.0.5",
     "chalk": "^2.3.0",
     "chromium-pickle-js": "^0.2.0",
@@ -95,7 +95,7 @@
     "gitbook-plugin-github": "^2.0.0",
     "gitbook-plugin-github-buttons": "^3.0.0",
     "globby": "^7.1.1",
-    "jest-cli": "^22.0.6",
+    "jest-cli": "^22.1.1",
     "jest-junit": "^3.4.1",
     "jsdoc-to-markdown": "^3.0.4",
     "path-sort": "^0.1.0",

diff --git a/packages/electron-builder-lib/src/options/macOptions.ts b/packages/electron-builder-lib/src/options/macOptions.ts
@@ -75,6 +75,11 @@ export interface MacConfiguration extends PlatformSpecificBuildOptions {
    */
   readonly binaries?: Array<string> | null
 
+  /**
+   * The minimum version of macOS required for the app to run. Corresponds to `LSMinimumSystemVersion`.
+   */
+  readonly minimumSystemVersion?: string | null
+
   /**
    * Path of [requirements file](https://developer.apple.com/library/mac/documentation/Security/Conceptual/CodeSigningGuide/RequirementLang/RequirementLang.html) used in signing. Not applicable for MAS.
    */

diff --git a/packages/electron-builder-lib/src/packager/mac.ts b/packages/electron-builder-lib/src/packager/mac.ts
@@ -46,7 +46,7 @@ export async function createMacApp(packager: PlatformPackager<any>, appOutDir: s
   const helperEHPlist = parsePlist(fileContents[2])
   const helperNPPlist = parsePlist(fileContents[3])
 
-  // If an extend-info file was supplied, copy its contents in first
+  // if an extend-info file was supplied, copy its contents in first
   if (fileContents[4] != null) {
     Object.assign(appPlist, parsePlist(fileContents[4]))
   }
@@ -92,6 +92,10 @@ export async function createMacApp(packager: PlatformPackager<any>, appOutDir: s
   appPlist.CFBundleShortVersionString = macOptions.bundleShortVersion || appInfo.version
   appPlist.CFBundleVersion = appInfo.buildVersion
 
+  if (macOptions.minimumSystemVersion != null) {
+    appPlist.LSMinimumSystemVersion = macOptions.minimumSystemVersion
+  }
+
   const protocols = asArray(buildMetadata.protocols).concat(asArray(packager.platformSpecificBuildOptions.protocols))
   if (protocols.length > 0) {
     appPlist.CFBundleURLTypes = protocols.map(protocol => {

diff --git a/packages/electron-publisher-s3/package.json b/packages/electron-publisher-s3/package.json
@@ -12,7 +12,7 @@
   ],
   "dependencies": {
     "fs-extra-p": "^4.5.0",
-    "aws-sdk": "^2.181.0",
+    "aws-sdk": "^2.182.0",
     "mime": "^2.2.0",
     "electron-publish": "~0.0.0-semantic-release",
     "builder-util": "^0.0.0-semantic-release",

diff --git a/test/out/mac/__snapshots__/macPackagerTest.js.snap b/test/out/mac/__snapshots__/macPackagerTest.js.snap
@@ -98,7 +98,7 @@ Object {
   "DTXcode": "0821",
   "DTXcodeBuild": "8C1002",
   "LSApplicationCategoryType": "your.app.category.type",
-  "LSMinimumSystemVersion": "10.9.0",
+  "LSMinimumSystemVersion": "10.12.0",
   "LSUIElement": true,
   "NSHighResolutionCapable": true,
   "NSMainNibFile": "MainMenu",

diff --git a/test/src/mac/macPackagerTest.ts b/test/src/mac/macPackagerTest.ts
@@ -35,6 +35,7 @@ test.ifMac("one-package", app({
       extendInfo: {
         LSUIElement: true,
       },
+      minimumSystemVersion: "10.12.0",
       fileAssociations: [
         {
           ext: "foo",