feat: Ability to set author/CompanyName programmatically

Closes #455
electron-userland · Jun 11, 2016 · 63c2529 · 63c2529
1 parent e5b0c04
commit 63c2529
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 4 deletions.
diff --git a/src/packager.ts b/src/packager.ts
@@ -59,7 +59,7 @@ export class Packager implements BuildInfo {
     this.isTwoPackageJsonProjectLayoutUsed = this.appDir !== this.projectDir
 
     const appPackageFile = this.projectDir === this.appDir ? devPackageFile : path.join(this.appDir, "package.json")
-    this.metadata = appPackageFile === devPackageFile ? this.devMetadata : await readPackageJson(appPackageFile)
+    this.metadata = appPackageFile === devPackageFile ? (this.options.appMetadata || this.devMetadata) : deepAssign(await readPackageJson(appPackageFile), this.options.appMetadata)
 
     this.checkMetadata(appPackageFile, devPackageFile)
     checkConflictingOptions(this.devMetadata.build)

diff --git a/src/platformPackager.ts b/src/platformPackager.ts
@@ -39,6 +39,13 @@ export interface PackagerOptions {
    * Development `package.json` will be still read, but options specified in this object will override.
    */
   readonly devMetadata?: DevMetadata
+
+  /**
+   * The same as [application package.json](https://github.com/electron-userland/electron-builder/wiki/Options#AppMetadata).
+   *
+   * Application `package.json` will be still read, but options specified in this object will override.
+   */
+  readonly appMetadata?: DevMetadata
 }
 
 export interface BuildInfo extends ProjectMetadataProvider {

diff --git a/test/src/ArtifactPublisherTest.ts b/test/src/ArtifactPublisherTest.ts
@@ -71,7 +71,7 @@ testAndIgnoreApiRate("prerelease", async () => {
     const r = await publisher.getRelease()
     assertThat(r).has.properties({
       prerelease: true,
-      draft: true,
+      draft: false,
     })
   }
   finally {

diff --git a/test/src/BuildTest.ts b/test/src/BuildTest.ts
@@ -85,9 +85,10 @@ test("name in the build", t => t.throws(assertPack("test-app-one", currentPlatfo
   })
 }), /'name' in the 'build' is forbidden/))
 
-test("empty description", t => t.throws(assertPack("test-app-one", {
+// this test also test appMetadata, so, we must use test-app here
+test("empty description", t => t.throws(assertPack("test-app", {
   targets: Platform.LINUX.createTarget(),
-  devMetadata: <any>{
+  appMetadata: <any>{
     description: "",
   }
 }), /Please specify 'description'/))